Hi Dave, Thanks. This provides a concrete path forward, and I am fine with delaying the activation of hidden visibility until after the VPP 26.10 branch pull on September 23.
I assume that 46753 in item 2 is a typo for 46573; 46753 is an unrelated CNAT change. I will address your review comments on 46747 and prepare a VPP 26.10 release note documenting: - the upcoming hidden-by-default behavior on master and in the release following 26.10; - the build-time compatibility option; - use of the out-of-tree plugin checker; - how to add and upstream any required __clib_export annotations. In the meantime, 46571, 46572 and 46573 are Verified +1. Reviews of 46571, 46572 and 46747 can therefore proceed now. I will not request submission of 46573 before the 26.10 branch has been pulled. Since the technical objections to 46573 are resolved, could you remove the Code-Review -2 now and record the agreed merge timing in a Gerrit comment? This would separate the completed technical review from the agreed scheduling constraint. Thanks, Jerome
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#27187): https://lists.fd.io/g/vpp-dev/message/27187 Mute This Topic: https://lists.fd.io/mt/121292132/21656 Group Owner: [email protected] Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/14379924/21656/631435203/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
