Hi Andrew, Thanks. This sequencing matches my understanding and provides a clear migration path:
- merge 46747, 46571, 46572 and the release note 46808 before the VPP 26.10 branch is pulled; - merge 46573 shortly after the branch pull. I assume 46753 in your message refers to 46573. With this sequence, VPP 26.10 retains the current visibility behavior while providing the checker, build support, documentation and advance notice. Hidden visibility becomes the default only on post-26.10 master, while the build-time compatibility option remains available. The ABI data posted separately also illustrates why this change is useful beyond its performance benefits. Since VPP 26.06, 86 exported libvnet interfaces have been added, 18 removed, and 9 existing function prototypes materially modified. Under the current visibility model, these changes affect an export surface that is not governed by an explicit export policy or systematic ABI check. Hidden visibility with explicit __clib_export annotations will turn that largely accidental export surface into an intentional and reviewable interface. Together with the in-tree checks and the standalone out-of-tree checker, it introduces more discipline around future changes and provides stronger guarantees and better visibility to downstream users. The community-call discussion supported moving forward with this approach, and I have not seen a request to treat this transition differently. The recent updates and rebases invalidated some of the previous reviews. Jeff, Andrew and Dave, could you please re-review the preparatory changes relevant to your areas and help get them merged before the 26.10 RC1 milestone? - 46747 - standalone out-of-tree checker and documentation https://gerrit.fd.io/r/c/vpp/+/46747 - 46571 - target-scoped hidden-visibility build support https://gerrit.fd.io/r/c/vpp/+/46571 - 46572 - removal of the packet-trace weak-symbol interposition https://gerrit.fd.io/r/c/vpp/+/46572 - 46808 - VPP 26.10 release-note announcement and migration guidance https://gerrit.fd.io/r/c/vpp/+/46808 In particular, Dave's comments on 46747 have been addressed in PS5, and Andrew's review of 46808 would confirm that the release note matches the intended release sequencing. Thanks, Jerome
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#27191): https://lists.fd.io/g/vpp-dev/message/27191 Mute This Topic: https://lists.fd.io/mt/121292132/21656 Group Owner: [email protected] Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/14379924/21656/631435203/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
