Per Inge Mathisen schreef:
On Mon, Jun 16, 2008 at 9:21 PM, Giel van Schijndel <[EMAIL PROTECTED]> wrote:Per Inge Mathisen schreef:Here is what I would like to see: 1) Every patch goes into the patch tracker. Give a quick run down of what it does and what it changes. 2) After a patch has been put into the patch tracker, give this list 48 hours to comment on it. Exception for patches that *only* fixes bugs that makes the game unplayabled or fixes build errors....Actually, I'm not even sure that I even *want* to see big patches getting done really. I'd much rather see changes being committed as several smaller patches, thus increasing their granularity and making them easier to be understood by others.Well pointed out. I would add these points then: 3) Try to break up larger changes into smaller patches when possible. 4) Do not mix unrelated cleanup and feature changes or bug fixes in the same patch. 5) Fix the coding style of lines you edit, but not that of any other lines.
Actually I'd rephrase 5 to something like this:5) Fix the coding style of lines you edit and the single function surrounding these lines, not that of other lines, and commit the coding style changes _separately_ from the non-style changes.
-- Giel
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
