After some discussion, I would like to soften the suggestion a bit: Commit guidelines: 1) All larger patches should go into the patch tracker. Give people time to comment on it. Add yourself to the cc: list of patches you are interested in. 2) Try to break up larger changes into smaller patches when possible. 3) Do not mix unrelated cleanup and feature changes or bug fixes in the same patch. 4) Fix the coding style of lines you edit, but try to avoid doing that to any other lines. 5) Be very careful about cleaning up code that other people may be working on.
I would like to emphasise the last point. It is very demotivating to see someone else's quick cleanup work rip asunder the careful rewriting you've been carrying on over several months to some part of the codebase, but not yet committed. - Per _______________________________________________ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
