Am Montag, 16. Juni 2008 23:25:54 schrieb Giel van Schijndel: > Per Inge Mathisen schreef: > > After some discussion, I would like to soften the suggestion a bit: > > > > Commit guidelines: > > 1) All larger patches should go into the patch tracker. Give people > > time to comment on it. Add yourself to the cc: list of patches you are > > interested in. > > 2) Try to break up larger changes into smaller patches when possible. > > 3) Do not mix unrelated cleanup and feature changes or bug fixes in > > the same patch. > > 4) Fix the coding style of lines you edit, but try to avoid doing that > > to any other lines. > > 5) Be very careful about cleaning up code that other people may be > > working on. > > > > I would like to emphasise the last point. It is very demotivating to > > see someone else's quick cleanup work rip asunder the careful > > rewriting you've been carrying on over several months to some part of > > the codebase, but not yet committed. > > This last point (5) of course depends on people communicating that they > are working on some large portion of code. Thus if you are working on a > large patch and expect other people to help prevent conflicting changes, > then communicate it through *this* list. You can use other communication > channels as well of course, but this list is the surest way of getting > any kind of "guarantee". Also if you're finished make sure to > communicate that through thist list as well. > > Thus: don't expect people to magically know that some piece of code is > undergoing extensive work by you. Communicate it! Sounds ok. (The proposal, too.) Though I think we shouldn't get too strict about this. It's still open, fun, colourful and so on.
ANNOUNCEMENT: I claim the raycasting and projectile code to be mine for the next weeks. :) --Dennis
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
