On Sun, Nov 28, 2010 at 10:21 PM,  <nore...@github.com> wrote:
> Branch: refs/heads/3.0
> Home:   https://github.com/Warzone2100/warzone2100
>
> Commit: cc0756a10adaf59e67dd29e13ad60cdd75e43514
>    
> https://github.com/Warzone2100/warzone2100/commit/cc0756a10adaf59e67dd29e13ad60cdd75e43514
> Author: safety0ff <safety...@users.sourceforge.net>
> Date:   2010-11-28 (Sun, 28 Nov 2010)
>
> Changed paths:
>  M src/projectile.c
>
> Log Message:
> -----------
> Use the stats  to determine struct height and clean up establishTargetHeight 
> function.
> This should improve shooting over structures in 3.0.
>
> Refs #2331.

Can you say a little bit more about why you think this is a good solution?

To me, this looks like a huge hack. Stats height values > 1 have never
been used before, AFAICT, so they might be random for all I know.
Instinctively I would think that it is better to find the height from
the model, instead of looking some number up in a stats file (which
sounds like unnecessary duplication of data).

  - Per

_______________________________________________
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev

Reply via email to