----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3882/#review5127 -----------------------------------------------------------
Is there a reason you are using a semi colon instead of a comma like the bug suggestion. Is the standard for email to use commas? If so maybe we should use that instead. I suppose different programs might do it differently. In which case I suppose either is fine. In either case we should probably put a hint as to what the delimiter is somewhere in the add participants dialog. "a/C://wintmp//Par1B9.tmp//ParticipantController-HEAD-left.java" <https://reviews.apache.org/r/3882/#comment11229> Should we change the prompt to be something like "Add participant(s): " an / or let them know that they can add multiple participants using a delimiter? "a/C://wintmp//Par1B9.tmp//ParticipantController-HEAD-left.java" <https://reviews.apache.org/r/3882/#comment11228> Two comments. 1) perhaps we should separate the addresses with a comma instead of a space. 2) Is there any information we can extract from the exception here in relation to the address that was not valid to add to the error message? - Michael On 2012-02-13 22:56:00, rocklund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3882/ > ----------------------------------------------------------- > > (Updated 2012-02-13 22:56:00) > > > Review request for wave. > > > Summary > ------- > > Implemented as suggested in the jira-issue as a client side implementation in > ParticipantController.java. I selected the separator for the multiple > participant list to be semi-colon(;). > > > This addresses bug wave-317. > https://issues.apache.org/jira/browse/wave-317 > > > Diffs > ----- > > "a/C://wintmp//Par1B9.tmp//ParticipantController-HEAD-left.java" ec9e25a > > Diff: https://reviews.apache.org/r/3882/diff > > > Testing > ------- > > Compiled and run. > > * Tested to add single as well as multiple participants > * Tested to add participants both with and without @localhost > * Tested to add invalid participants > > > Thanks, > > rocklund > >
