-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3882/
-----------------------------------------------------------
(Updated 2012-02-16 19:19:37.700527)
Review request for wave.
Changes
-------
Thanks for the reviews. Updated according to the comments:
* Fixed indentation
* Added spaces in between arithmetical operations
* Updated to use equals instead of compareTo in unit test
* Moved the buildParticipantList method to the ParticipantController
* Moved the unit tests to the new class ParticipantControllerTest.java
* Added @Nullable annotation to localDomain
@Yuri: I don't understand how you mean that I can move the localDomain
null-check outside of the for-loop? The current address processed in the
for-loop is handled differently depending on the result of that null-check.
Summary
-------
Implemented as suggested in the jira-issue as a client side implementation in
ParticipantController.java. I selected the separator for the multiple
participant list to be semi-colon(;).
This addresses bug wave-317.
https://issues.apache.org/jira/browse/wave-317
Diffs (updated)
-----
src/org/waveprotocol/wave/client/wavepanel/impl/edit/ParticipantController.java
ec9e25a
test/org/waveprotocol/wave/client/wavepanel/impl/edit/ParticipantControllerTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/3882/diff
Testing
-------
Compiled and run.
* Tested to add single as well as multiple participants
* Tested to add participants both with and without @localhost
* Tested to add invalid participants
Thanks,
rocklund
