> On 2012-01-22 00:02:02, Michael MacFadden wrote: > > > > Ali Lown wrote: > Has this patch been stalled? It doesn't appear to have been committed > yet...
Yes, after thinking some more about it I am not sure this implementation is OK. The problem is - the blips receive the content asynchronously, and there's no good way to know when it happens in order to take the title from the blip document. The workaround here is to force the blips queue rendering but it makes the loading synchronous and this might raise performance issues. - Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3530/#review4517 ----------------------------------------------------------- On 2012-01-19 20:11:38, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3530/ > ----------------------------------------------------------- > > (Updated 2012-01-19 20:11:38) > > > Review request for wave, Michael MacFadden and Ali Lown. > > > Summary > ------- > > Sets the current wave title also as the browser window title. > > > Diffs > ----- > > src/org/waveprotocol/box/webclient/client/StagesProvider.java 8a5355a > src/org/waveprotocol/wave/client/StageThree.java f31ed3b > src/org/waveprotocol/wave/client/doodad/title/TitleAnnotationHandler.java > e8b13f7 > src/org/waveprotocol/wave/client/scroll/ProxyScrollPanel.java 27e5da7 > src/org/waveprotocol/wave/client/wavepanel/WavePanel.java d1944b7 > src/org/waveprotocol/wave/client/wavepanel/impl/WavePanelImpl.java 282387e > src/org/waveprotocol/wave/client/wavepanel/impl/edit/EditSession.java > b4f141b > > src/org/waveprotocol/wave/client/wavepanel/impl/focus/FocusFramePresenter.java > 1351987 > > src/org/waveprotocol/wave/client/wavepanel/impl/title/WindowTitleHandler.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3530/diff > > > Testing > ------- > > Tested locally, verified that the wave title also set as browser window title. > > > Thanks, > > Yuri > >
