> On 2012-05-05 15:12:42, Ali Lown wrote:
> > Rather than fully replacing the window title with the wave title, can we
> > have '{title} - WIAB' following GMail style?
I also was thinking about this, but wasn't sure what should be the template.
The first problem - I don't like when window titles have too much clutter when
bookmarked. The second problem - WIAB is not enough, we need to add the actual
WIAB domain (i.e. waveinabox.net). Gmail also specified the user id.
But if you think that we will be better off with GMail like template - it is
fine with me.
So, should we settle on the following template for title?
WIAB @example.com - the wave title - [email protected]
- Yuri
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3530/#review7599
-----------------------------------------------------------
On 2012-05-01 19:01:59, Yuri Zelikov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3530/
> -----------------------------------------------------------
>
> (Updated 2012-05-01 19:01:59)
>
>
> Review request for wave, Michael MacFadden and Ali Lown.
>
>
> Summary
> -------
>
> Sets the current wave title also as the browser window title.
>
>
> Diffs
> -----
>
>
> src/org/waveprotocol/wave/client/wavepanel/impl/title/WindowTitleHandler.java
> PRE-CREATION
> src/org/waveprotocol/box/webclient/client/StagesProvider.java 04ffd49
>
> Diff: https://reviews.apache.org/r/3530/diff
>
>
> Testing
> -------
>
> Tested locally, verified that the wave title also set as browser window title.
>
>
> Thanks,
>
> Yuri
>
>
