Alright, I've gone through all of the patches. The only bug I noticed was that buttons on erasers still don't register. I debugged this a little bit and found that libwacom doesn't parse the buttons value for erasers, so I've sent a patch for that to the libwacom mailing list :). Other then that, everything looks fine!
With that I can finally say this and feel cool:
Reviewed-by: Stephen Chandler Paul <thatsly...@gmail.com>
Cheers,
Lyude
On Tue, 2015-02-24 at 16:21 +1000, Peter Hutterer wrote:
> This is a v2 of the patchset here
> http://lists.freedesktop.org/archives/wayland-devel/2015-February/020036.html
> but reshuffled, rebased and a couple of things merged in. Notable:
> libinput now uses libwacom to get tool/tablet information. This is complete
> for this set yet, but a few more fixes are due to go into libwacom (e.g.
> axis listing) so we can remove this knowledge from libinput. Likewise, the
> missing eraser stylus buttons Lyude pointed out in the other thread will be
> fixed in libwacom.
>
> If libwacom isn't available, we fall back on basic logic to set the various
> bits on the tools.
>
> mouse buttons and the mouse wheel are now handled. art pen rotation is
> fixed, was relying on BTN_TOOL_BRUSH first - the art pen is a BTN_TOOL_PEN.
> other patches have seen a rebase and reshuffle and thus seen slight changes.
>
> added get_axis_delta and get_axis_delta_discrete(). The latter for the mouse
> wheel, the former allows the caller to make a decision about the tablet mode
> on a per-event or per-client basis.
>
> The couple of libwacom issues aside, this should make the tablet-support
> branch feature-complete.
>
> branch available for testing:
> https://github.com/whot/libinput/tree/wip/wacom-extra-tool-support
>
> Cheers,
> Peter
> _______________________________________________
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
signature.asc
Description: This is a digitally signed message part
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
