On Tue, May 26, 2015 at 04:06:37PM -0700, Jon A. Cruz wrote: > Added simple unit/integration test framework and corresponding > test program. > > Added a simple C-based test framework and an example program > that uses it to run through some simple wayland client checks.
You should elaborate on how this code originated. E.g. if it is derived from another codebase, mention that codebase. Otherwise, maybe list what your inspirations were, and/or where your ideas came from. Btw, thanks for your work here, this is very thorough. Looking forward to seeing this in use. Skimming through this big patch it looks similar to the v2 one I already reviewed, so assuming nothing major has changed since then, please refer to my earlier review. Hopefully there is something of usefulness to you in those comments. Bryce > Expanded code support in testing framework includes: > > * Running tests in forked child processes. > * Filtering of tests by both matches and exclusions. > * Per-suite and per-test setup and tear-down fixtures. > * Unconditional test stopping including skipping. > * Tracing of additional messages for failure logging. > * Works correctly with both debug and release builds (no assert, etc.) > * Randomization of tests. > * Repetition of tests. > * Parsing command-line parameters in test main()'s > * Return of proper exit codes including 77 for skip. > * Break on failure. > > Signed-off-by: Jon A. Cruz <j...@osg.samsung.com> > > Signed-off-by: Jon A. Cruz <j...@osg.samsung.com> [snip] _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
