On 21 October 2015 at 18:49, Nils Chr. Brause <nilschrbra...@gmail.com> wrote: > You are missing bitfield="true" for wl_shell_surface::resize and > wl_output::transform.
Scanning the weston source code, it seems you would have been right about wl_shell_surface had it not been replaced by xdg_shell_surface. But I am happy to add this for wl_shell_surface. wl_output::transform is not missing, I deliberately did not add this. Although it looks like a bit field at first sight, (according to the weston source code) its primary interface is case-wise processing. I could not find a single bitwise operation on it in the weston source code. If you'd like to add this (I would not be an opponent because I can see the value of bitfield="true" here), I propose you send in a later patch, because it will probably stir up a new discussion that I'd like to keep outside of the current one (of whether to do this at all). _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel