I did ( committing now) but I do not see any improvement.

On Monday, 15 April 2013 10:28:07 UTC-5, Paolo Caruccio wrote:
>
> Please replace the file web2py_bootstrap.js in welcome/static/js/ and 
> admin/static/js folders with the patched one.
>
> I added a function [adjust_height_of_collapsed_nav()] that adjusts the 
> height of the navbar on hover mouse event when it is collapsed (screen 
> width < 980px based on default bootstrap threshold). Unfortunately there is 
> a small initial spring effect, but I think that it is acceptable.
> I removed the client width check: now hoverMenu() function works also for 
> narrow screen.
>
> The code is very simple but if you need more details I'll be at your 
> disposal.
>
>
>
>
> Il giorno lunedì 15 aprile 2013 16:42:39 UTC+2, Massimo Di Pierro ha 
> scritto:
>>
>> Can you explain how that works?
>>
>> Il giorno lunedì 15 aprile 2013 05:47:48 UTC-5, Paolo Caruccio ha scritto:
>>>
>>> Patch sent
>>>
>>> https://code.google.com/p/web2py/issues/detail?id=1447
>>>
>>>
>>>
>>> Il giorno lunedì 15 aprile 2013 05:48:16 UTC+2, Massimo Di Pierro ha 
>>> scritto:
>>>>
>>>> Can you send me a patch? thanks.
>>>>
>>>> On Sunday, 14 April 2013 10:36:40 UTC-5, Paolo Caruccio wrote:
>>>>>
>>>>> I found the problem causing the submenu display failure. Twitter 
>>>>> bootstrap shows the submenu with the "click". In web2py, instead we use 
>>>>> the 
>>>>> "hover". Since bootstrap has implemented a js function that sets the 
>>>>> height 
>>>>> of the navbar, having the collapsed state, on click event we have to 
>>>>> override it.
>>>>> I added a function that adjusts the height of the navbar on hover 
>>>>> event. Unfortunately there is a small initial spring effect, but I think 
>>>>> that it is acceptable.
>>>>> I will send a patch in the next few minutes.
>>>>>
>>>>> Regarding the size of the small button you can increase it by simple 
>>>>> css rules. For example:
>>>>>
>>>>> . navbar. btn-navbar. icon-bar {
>>>>> width: 36px;
>>>>> height: 4px;
>>>>> }
>>>>> . btn-navbar. icon-bar +. icon-bar {
>>>>> margin-top: 6px;
>>>>> }
>>>>>
>>>>> to be added to the section "Overriding Bootstrap.css Rules" in 
>>>>> web2py_bootstrap.css. But I think it's a question of taste so it is in my 
>>>>> opinion that it is preferable to leave the default values in the 
>>>>> distributed version of web2py.
>>>>>
>>>>> Finally, I noticed that in web2py we have an old version of jquery 
>>>>> (1.8.3 vs 1.9.1) and an old version of bootstrap (2.2.2 vs 31.2). I'm 
>>>>> pretty sure that updating these technologies does not lead to side 
>>>>> effects.
>>>>>
>>>>>
>>>>> Il giorno domenica 14 aprile 2013 16:52:03 UTC+2, Massimo Di Pierro ha 
>>>>> scritto:
>>>>>>
>>>>>> Can we increase width that triggers the first behavior (small button)?
>>>>>>
>>>>>> On Sunday, 14 April 2013 05:06:01 UTC-5, Paolo Caruccio wrote:
>>>>>>>
>>>>>>> The first behavior (a small button is shown on narrow screen) is 
>>>>>>> normal. The second no. Original behavior was to show all submenu when 
>>>>>>> you 
>>>>>>> clicked on small button. You could check this on web2py 2.3.0. 
>>>>>>> Something 
>>>>>>> broke this I'll investigate and submit a patch asap.
>>>>>>>
>>>>>>> Il giorno sabato 13 aprile 2013 23:29:39 UTC+2, Massimo Di Pierro ha 
>>>>>>> scritto:
>>>>>>>>
>>>>>>>> In twitter bootstrap and web2py when the screen is too narrow the 
>>>>>>>> menu display as a single button which triggers a drop down. This 
>>>>>>>> happens to 
>>>>>>>> me  every time I give a talk and the menu disappears because the 
>>>>>>>> screen 
>>>>>>>> gets narrower on a projector. Moreover when the menu is a dropdown, 
>>>>>>>> submenus do not work?
>>>>>>>>
>>>>>>>> Any suggestions for changing this behavior?
>>>>>>>>
>>>>>>>> Massimo 
>>>>>>>>
>>>>>>>

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"web2py-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to web2py+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to