That line is needed to make sure that if Field (...'upload',requires=IS_NOT_EMPTY()) validated on update even when a file is already updated and the update is not allowed to delete the uploloaded file without replacement.
On Jul 10, 3:24 pm, Hans Donner <hans.don...@pobox.com> wrote: > it's certainly improved and for my test setup it works > > On Fri, Jul 10, 2009 at 10:18 PM, mdipierro<mdipie...@cs.depaul.edu> wrote: > > > You are right. I think I fixed the fix and I am uploading 1017. Please > > give it a try. > > > On Jul 10, 2:32 pm, Hans Donner <hans.don...@pobox.com> wrote: > >> Yep, > > >> Massimo, your last fix broke it (line 737+), esp the > >> if not self.errors: ret = true > > >> here ret is set to true where it shouldn't be... > > >> On Fri, Jul 10, 2009 at 3:21 PM, annet<annet.verm...@gmail.com> wrote: > > >> > Hans, > > >> >> What version where you using before (please spicy svn or > >> >> bazaar/launchpad) ? > >> > I was using the sqlhtml file that came with the source code of web2py > >> > version 1.65.0. > > >> >> Can you (perhpas) try what version is still working: see > >> >> eghttp://bazaar.launchpad.net/~mdipierro/web2py/devel/changes?filter_fi... > >> > (bazaar launchpad) I checked all versions of the sqlhtml.py file from > >> > 1005 upward, version 1011 is the last one that works, version 1013 > >> > breaks the update function, as does version 1014. > > >> >> Can you show some simple code that we can use to reproduce this? > >> > I wanted to update a record using the web2py's admin when I discovered > >> > that the update function no longer works, my own update functions > >> > call > >> > the update function: > > >> > @auth.requires_membership('tier2_manager') > >> > def update_openinghour(): > >> > response.view='tier1/update.html' > >> > db.openingstijd.bedrijf.writable=False > >> > record=db.openingstijd[request.args[0]] > >> > if not record or not record.bedrijf==auth.user.bedrijf: > >> > redirect(URL(r=request,f='crud_openinghour')) > >> > form=update_form(db.openingstijd,record,'crud_openinghour') > >> > return dict(form=form) > >> > def update_form(table,rec,nxt): > >> > form=crud.update(table,rec,next=(URL(r=request,f=nxt))) > >> > form[0][-1][1].append(INPUT > >> > (_type='button',_value='Cancel',_onclick='javascript:history.go > >> > (-1)')) > >> > return form > > >> > Kind regards, > > >> > Annet. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "web2py Web Framework" group. To post to this group, send email to web2py@googlegroups.com To unsubscribe from this group, send email to web2py+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/web2py?hl=en -~----------~----~----~----~------~----~------~--~---