Title: [200893] trunk/Source/_javascript_Core
- Revision
- 200893
- Author
- joep...@webkit.org
- Date
- 2016-05-13 16:29:13 -0700 (Fri, 13 May 2016)
Log Message
Web Inspector: Inform augmenting client when inspector controller is destroyed
https://bugs.webkit.org/show_bug.cgi?id=157688
<rdar://problem/25832724>
Reviewed by Timothy Hatcher.
* inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::~JSGlobalObjectInspectorController):
* inspector/augmentable/AugmentableInspectorControllerClient.h:
There is a weak relationship between the InspectorController and the
AugmentingClient. Let the augmenting client know when the controller
is destroyed so it doesn't try to use us anymore.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (200892 => 200893)
--- trunk/Source/_javascript_Core/ChangeLog 2016-05-13 23:28:35 UTC (rev 200892)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-05-13 23:29:13 UTC (rev 200893)
@@ -1,3 +1,18 @@
+2016-05-13 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Inform augmenting client when inspector controller is destroyed
+ https://bugs.webkit.org/show_bug.cgi?id=157688
+ <rdar://problem/25832724>
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/JSGlobalObjectInspectorController.cpp:
+ (Inspector::JSGlobalObjectInspectorController::~JSGlobalObjectInspectorController):
+ * inspector/augmentable/AugmentableInspectorControllerClient.h:
+ There is a weak relationship between the InspectorController and the
+ AugmentingClient. Let the augmenting client know when the controller
+ is destroyed so it doesn't try to use us anymore.
+
2016-05-13 Geoffrey Garen <gga...@apple.com>
Runaway malloc memory usage in this simple JSC program
Modified: trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.cpp (200892 => 200893)
--- trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.cpp 2016-05-13 23:28:35 UTC (rev 200892)
+++ trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.cpp 2016-05-13 23:29:13 UTC (rev 200893)
@@ -106,6 +106,10 @@
JSGlobalObjectInspectorController::~JSGlobalObjectInspectorController()
{
+#if ENABLE(INSPECTOR_ALTERNATE_DISPATCHERS)
+ if (m_augmentingClient)
+ m_augmentingClient->inspectorControllerDestroyed();
+#endif
}
void JSGlobalObjectInspectorController::globalObjectDestroyed()
Modified: trunk/Source/_javascript_Core/inspector/augmentable/AugmentableInspectorControllerClient.h (200892 => 200893)
--- trunk/Source/_javascript_Core/inspector/augmentable/AugmentableInspectorControllerClient.h 2016-05-13 23:28:35 UTC (rev 200892)
+++ trunk/Source/_javascript_Core/inspector/augmentable/AugmentableInspectorControllerClient.h 2016-05-13 23:29:13 UTC (rev 200893)
@@ -33,6 +33,7 @@
class AugmentableInspectorControllerClient {
public:
virtual ~AugmentableInspectorControllerClient() { }
+ virtual void inspectorControllerDestroyed() = 0;
virtual void inspectorConnected() = 0;
virtual void inspectorDisconnected() = 0;
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
