Title: [200896] trunk/Source/_javascript_Core
Revision
200896
Author
benja...@webkit.org
Date
2016-05-13 16:44:31 -0700 (Fri, 13 May 2016)

Log Message

[JSC] Emit the loads of emitLoadWithStructureCheck() in the order they are used
https://bugs.webkit.org/show_bug.cgi?id=157671

Patch by Benjamin Poulain <bpoul...@apple.com> on 2016-05-13
Reviewed by Mark Lam.

This improves the chances of having a value
when issuing the TEST.

* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitLoadWithStructureCheck):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (200895 => 200896)


--- trunk/Source/_javascript_Core/ChangeLog	2016-05-13 23:42:17 UTC (rev 200895)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-05-13 23:44:31 UTC (rev 200896)
@@ -1,3 +1,16 @@
+2016-05-13  Benjamin Poulain  <bpoul...@apple.com>
+
+        [JSC] Emit the loads of emitLoadWithStructureCheck() in the order they are used
+        https://bugs.webkit.org/show_bug.cgi?id=157671
+
+        Reviewed by Mark Lam.
+
+        This improves the chances of having a value
+        when issuing the TEST.
+
+        * jit/JITPropertyAccess.cpp:
+        (JSC::JIT::emitLoadWithStructureCheck):
+
 2016-05-13  Joseph Pecoraro  <pecor...@apple.com>
 
         Web Inspector: Inform augmenting client when inspector controller is destroyed

Modified: trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp (200895 => 200896)


--- trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp	2016-05-13 23:42:17 UTC (rev 200895)
+++ trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp	2016-05-13 23:44:31 UTC (rev 200896)
@@ -801,8 +801,8 @@
 
 void JIT::emitLoadWithStructureCheck(int scope, Structure** structureSlot)
 {
+    loadPtr(structureSlot, regT1);
     emitGetVirtualRegister(scope, regT0);
-    loadPtr(structureSlot, regT1);
     addSlowCase(branchTestPtr(Zero, regT1));
     load32(Address(regT1, Structure::structureIDOffset()), regT1);
     addSlowCase(branch32(NotEqual, Address(regT0, JSCell::structureIDOffset()), regT1));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to