Title: [211486] trunk/Source/_javascript_Core
- Revision
- 211486
- Author
- commit-qu...@webkit.org
- Date
- 2017-02-01 09:34:00 -0800 (Wed, 01 Feb 2017)
Log Message
Web Inspector: Use guaranteed RunLoop instead of RunLoop::current for dispatching inspector GC event
https://bugs.webkit.org/show_bug.cgi?id=167683
<rdar://problem/30167791>
Patch by Joseph Pecoraro <pecor...@apple.com> on 2017-02-01
Reviewed by Timothy Hatcher.
* inspector/agents/InspectorHeapAgent.cpp:
(Inspector::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):
Use RunLoop::main instead of RunLoop::current which may go away.
* runtime/InitializeThreading.cpp:
(JSC::initializeThreading):
Ensure RunLoop::main is initialized when using JSC APIs.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (211485 => 211486)
--- trunk/Source/_javascript_Core/ChangeLog 2017-02-01 17:33:56 UTC (rev 211485)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-02-01 17:34:00 UTC (rev 211486)
@@ -1,3 +1,19 @@
+2017-02-01 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Use guaranteed RunLoop instead of RunLoop::current for dispatching inspector GC event
+ https://bugs.webkit.org/show_bug.cgi?id=167683
+ <rdar://problem/30167791>
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/agents/InspectorHeapAgent.cpp:
+ (Inspector::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):
+ Use RunLoop::main instead of RunLoop::current which may go away.
+
+ * runtime/InitializeThreading.cpp:
+ (JSC::initializeThreading):
+ Ensure RunLoop::main is initialized when using JSC APIs.
+
2017-02-01 Yusuke Suzuki <utatane....@gmail.com>
ArityFixup should adjust SP first
Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorHeapAgent.cpp (211485 => 211486)
--- trunk/Source/_javascript_Core/inspector/agents/InspectorHeapAgent.cpp 2017-02-01 17:33:56 UTC (rev 211485)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorHeapAgent.cpp 2017-02-01 17:34:00 UTC (rev 211486)
@@ -61,7 +61,7 @@
SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask(HeapFrontendDispatcher& frontendDispatcher)
: m_frontendDispatcher(frontendDispatcher)
- , m_timer(RunLoop::current(), this, &SendGarbageCollectionEventsTask::timerFired)
+ , m_timer(RunLoop::main(), this, &SendGarbageCollectionEventsTask::timerFired)
{
}
Modified: trunk/Source/_javascript_Core/runtime/InitializeThreading.cpp (211485 => 211486)
--- trunk/Source/_javascript_Core/runtime/InitializeThreading.cpp 2017-02-01 17:33:56 UTC (rev 211485)
+++ trunk/Source/_javascript_Core/runtime/InitializeThreading.cpp 2017-02-01 17:34:00 UTC (rev 211486)
@@ -32,17 +32,18 @@
#include "ExecutableAllocator.h"
#include "Heap.h"
#include "HeapStatistics.h"
-#include "Options.h"
#include "Identifier.h"
#include "JSDateMath.h"
#include "JSGlobalObject.h"
#include "JSLock.h"
#include "LLIntData.h"
+#include "Options.h"
#include "StructureIDTable.h"
#include "SuperSampler.h"
#include "WriteBarrier.h"
#include <mutex>
#include <wtf/MainThread.h>
+#include <wtf/RunLoop.h>
#include <wtf/Threading.h>
#include <wtf/dtoa.h>
#include <wtf/dtoa/cached-powers.h>
@@ -59,6 +60,7 @@
WTF::double_conversion::initialize();
WTF::initializeThreading();
WTF::initializeGCThreads();
+ RunLoop::initializeMainRunLoop();
Options::initialize();
if (Options::recordGCPauseTimes())
HeapStatistics::initialize();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
