Title: [211485] trunk/Source/WebInspectorUI
- Revision
- 211485
- Author
- commit-qu...@webkit.org
- Date
- 2017-02-01 09:33:56 -0800 (Wed, 01 Feb 2017)
Log Message
Web Inspector: Remove keyboard shortcut to close tab - does not match expectations
https://bugs.webkit.org/show_bug.cgi?id=167672
Patch by Joseph Pecoraro <pecor...@apple.com> on 2017-02-01
Reviewed by Timothy Hatcher.
* UserInterface/Views/TabBrowser.js:
(WebInspector.TabBrowser):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (211484 => 211485)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-02-01 16:17:52 UTC (rev 211484)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-02-01 17:33:56 UTC (rev 211485)
@@ -1,3 +1,13 @@
+2017-02-01 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Remove keyboard shortcut to close tab - does not match expectations
+ https://bugs.webkit.org/show_bug.cgi?id=167672
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/TabBrowser.js:
+ (WebInspector.TabBrowser):
+
2017-01-31 Devin Rousso <dcrousso+web...@gmail.com>
Web Inspector: Tooltip text should not end in a period
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js (211484 => 211485)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js 2017-02-01 16:17:52 UTC (rev 211484)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js 2017-02-01 17:33:56 UTC (rev 211485)
@@ -53,14 +53,7 @@
let showNextTab = () => { this._showNextTab(); };
let showPreviousTab = () => { this._showPreviousTab(); };
- let closeCurrentTab = () => {
- let selectedTabBarItem = this._tabBar.selectedTabBarItem;
- if (this._tabBar.tabBarItems.length > 3 || !selectedTabBarItem.isDefaultTab)
- this._tabBar.removeTabBarItem(selectedTabBarItem);
- };
- this._closeCurrentTabKeyboardShortuct = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Shift, "W", closeCurrentTab);
-
this._showNextTabKeyboardShortcut1 = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Shift, WebInspector.KeyboardShortcut.Key.RightCurlyBrace, showNextTab);
this._showPreviousTabKeyboardShortcut1 = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Shift, WebInspector.KeyboardShortcut.Key.LeftCurlyBrace, showPreviousTab);
this._showNextTabKeyboardShortcut2 = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Control, WebInspector.KeyboardShortcut.Key.Tab, showNextTab);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
