Title: [99562] trunk/LayoutTests
- Revision
- 99562
- Author
- zimmerm...@webkit.org
- Date
- 2011-11-08 06:19:40 -0800 (Tue, 08 Nov 2011)
Log Message
2011-11-08 Nikolas Zimmermann <nzimmerm...@rim.com>
[Chromium] SVG test failures after r99539
https://bugs.webkit.org/show_bug.cgi?id=71793
Reviewed by Zoltan Herczeg.
It turns out that some of these tests are flakey. Replace <animate> elements with <set>.
That still tests repaint, but there's no need to run a 100ms animation, and then sample it after 400ms.
That cries for problems if the machine is slow or loaded.
I left the 400ms sample snapshot for now, we can still relax it later.
* fast/backgrounds/resources/animated-rect-relative-size.svg:
* svg/as-background-image/resources/animated-rect-relative-size.svg:
* svg/as-image/resources/animated-rect-fixed-size.svg:
* svg/as-image/resources/animated-rect-relative-size.svg:
* svg/as-image/resources/animated-rect-same-image.svg:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (99561 => 99562)
--- trunk/LayoutTests/ChangeLog 2011-11-08 14:14:35 UTC (rev 99561)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 14:19:40 UTC (rev 99562)
@@ -1,3 +1,22 @@
+2011-11-08 Nikolas Zimmermann <nzimmerm...@rim.com>
+
+ [Chromium] SVG test failures after r99539
+ https://bugs.webkit.org/show_bug.cgi?id=71793
+
+ Reviewed by Zoltan Herczeg.
+
+ It turns out that some of these tests are flakey. Replace <animate> elements with <set>.
+ That still tests repaint, but there's no need to run a 100ms animation, and then sample it after 400ms.
+ That cries for problems if the machine is slow or loaded.
+
+ I left the 400ms sample snapshot for now, we can still relax it later.
+
+ * fast/backgrounds/resources/animated-rect-relative-size.svg:
+ * svg/as-background-image/resources/animated-rect-relative-size.svg:
+ * svg/as-image/resources/animated-rect-fixed-size.svg:
+ * svg/as-image/resources/animated-rect-relative-size.svg:
+ * svg/as-image/resources/animated-rect-same-image.svg:
+
2011-11-08 Yuta Kitamura <yu...@chromium.org>
[Chromium] Unreviewed, add three more CG-only failures.
Modified: trunk/LayoutTests/fast/backgrounds/resources/animated-rect-relative-size.svg (99561 => 99562)
--- trunk/LayoutTests/fast/backgrounds/resources/animated-rect-relative-size.svg 2011-11-08 14:14:35 UTC (rev 99561)
+++ trunk/LayoutTests/fast/backgrounds/resources/animated-rect-relative-size.svg 2011-11-08 14:19:40 UTC (rev 99562)
@@ -21,7 +21,7 @@
<text font-size="36" x="20" y="140">6</text>
<line x1="30" y1="0" x2="30" y2="100" fill="none" stroke="#880000" />
<rect x="0" y="0" width="300" height="80" fill="#44AAFF" stroke="#880088" stroke-width="4" >
- <animate attributeName="width" calcMode="discrete" values="300;30" keyTimes="0;.6" begin="0s" dur="100ms" fill="freeze"/>
+ <set attributeName="width" to="30" begin="0s" fill="freeze"/>
</rect>
</g>
</g>
Modified: trunk/LayoutTests/svg/as-background-image/resources/animated-rect-relative-size.svg (99561 => 99562)
--- trunk/LayoutTests/svg/as-background-image/resources/animated-rect-relative-size.svg 2011-11-08 14:14:35 UTC (rev 99561)
+++ trunk/LayoutTests/svg/as-background-image/resources/animated-rect-relative-size.svg 2011-11-08 14:19:40 UTC (rev 99562)
@@ -21,7 +21,7 @@
<text font-size="36" x="20" y="140">6</text>
<line x1="30" y1="0" x2="30" y2="100" fill="none" stroke="#880000" />
<rect x="0" y="0" width="300" height="80" fill="#44AAFF" stroke="#880088" stroke-width="4" >
- <animate attributeName="width" calcMode="discrete" values="300;30" keyTimes="0;.6" begin="0s" dur="100ms" fill="freeze"/>
+ <set attributeName="width" to="30" begin="0s" fill="freeze"/>
</rect>
</g>
</g>
Modified: trunk/LayoutTests/svg/as-image/resources/animated-rect-fixed-size.svg (99561 => 99562)
--- trunk/LayoutTests/svg/as-image/resources/animated-rect-fixed-size.svg 2011-11-08 14:14:35 UTC (rev 99561)
+++ trunk/LayoutTests/svg/as-image/resources/animated-rect-fixed-size.svg 2011-11-08 14:19:40 UTC (rev 99562)
@@ -21,7 +21,7 @@
<text font-size="36" x="20" y="140">6</text>
<line x1="30" y1="0" x2="30" y2="100" fill="none" stroke="#880000" />
<rect x="0" y="0" width="300" height="80" fill="#44AAFF" stroke="#880088" stroke-width="4" >
- <animate attributeName="width" calcMode="discrete" values="300;30" keyTimes="0;.6" begin="0s" dur="100ms" fill="freeze"/>
+ <set attributeName="width" to="30" begin="0s" fill="freeze"/>
</rect>
</g>
</g>
Modified: trunk/LayoutTests/svg/as-image/resources/animated-rect-relative-size.svg (99561 => 99562)
--- trunk/LayoutTests/svg/as-image/resources/animated-rect-relative-size.svg 2011-11-08 14:14:35 UTC (rev 99561)
+++ trunk/LayoutTests/svg/as-image/resources/animated-rect-relative-size.svg 2011-11-08 14:19:40 UTC (rev 99562)
@@ -21,7 +21,7 @@
<text font-size="36" x="20" y="140">6</text>
<line x1="30" y1="0" x2="30" y2="100" fill="none" stroke="#880000" />
<rect x="0" y="0" width="300" height="80" fill="#44AAFF" stroke="#880088" stroke-width="4" >
- <animate attributeName="width" calcMode="discrete" values="300;30" keyTimes="0;.6" begin="0s" dur="100ms" fill="freeze"/>
+ <set attributeName="width" to="30" begin="0s" fill="freeze"/>
</rect>
</g>
</g>
Modified: trunk/LayoutTests/svg/as-image/resources/animated-rect-same-image.svg (99561 => 99562)
--- trunk/LayoutTests/svg/as-image/resources/animated-rect-same-image.svg 2011-11-08 14:14:35 UTC (rev 99561)
+++ trunk/LayoutTests/svg/as-image/resources/animated-rect-same-image.svg 2011-11-08 14:19:40 UTC (rev 99562)
@@ -21,7 +21,7 @@
<text font-size="36" x="20" y="140">6</text>
<line x1="30" y1="0" x2="30" y2="100" fill="none" stroke="#880000" />
<rect x="0" y="0" width="300" height="80" fill="#44AAFF" stroke="#880088" stroke-width="4" >
- <animate attributeName="width" calcMode="discrete" values="300;30" keyTimes="0;.6" begin="0s" dur="100ms" fill="freeze"/>
+ <set attributeName="width" to="30" begin="0s" fill="freeze"/>
</rect>
</g>
</g>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes