Title: [99563] trunk/Source/WebCore
Revision
99563
Author
pfeld...@chromium.org
Date
2011-11-08 06:36:47 -0800 (Tue, 08 Nov 2011)

Log Message

Web Inspector: add _javascript_ keywords to the autocomplete.
https://bugs.webkit.org/show_bug.cgi?id=71782

Reviewed by Yury Semikhatsky.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype._reportCompletions):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (99562 => 99563)


--- trunk/Source/WebCore/ChangeLog	2011-11-08 14:19:40 UTC (rev 99562)
+++ trunk/Source/WebCore/ChangeLog	2011-11-08 14:36:47 UTC (rev 99563)
@@ -1,3 +1,15 @@
+2011-11-08  Pavel Feldman  <pfeld...@google.com>
+
+        Web Inspector: add _javascript_ keywords to the autocomplete.
+        https://bugs.webkit.org/show_bug.cgi?id=71782
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/ConsoleView.js:
+        (WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
+        (WebInspector.ConsoleView.prototype._completions):
+        (WebInspector.ConsoleView.prototype._reportCompletions):
+
 2011-11-08  Nikolas Zimmermann  <nzimmerm...@rim.com>
 
         Introduce SVGLengthContext, to allow to resolve relative units to arbitary viewports

Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (99562 => 99563)


--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js	2011-11-08 14:19:40 UTC (rev 99562)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js	2011-11-08 14:36:47 UTC (rev 99563)
@@ -428,11 +428,11 @@
                 for (var i = 0; i < commandLineAPI.length; ++i)
                     propertyNames[commandLineAPI[i]] = true;
             }
-            this._reportCompletions(completionsReadyCallback, dotNotation, bracketNotation, prefix, Object.keys(propertyNames));
+            this._reportCompletions(completionsReadyCallback, dotNotation, bracketNotation, expressionString, prefix, Object.keys(propertyNames));
         }
     },
 
-    _reportCompletions: function(completionsReadyCallback, dotNotation, bracketNotation, prefix, properties) {
+    _reportCompletions: function(completionsReadyCallback, dotNotation, bracketNotation, expressionString, prefix, properties) {
         if (bracketNotation) {
             if (prefix.length && prefix[0] === "'")
                 var quoteUsed = "'";
@@ -441,6 +441,13 @@
         }
 
         var results = [];
+
+        if (!expressionString) {
+            const keywords = ["break", "case", "catch", "continue", "default", "delete", "do", "else", "finally", "for", "function", "if", "in",
+                              "instanceof", "new", "return", "switch", "this", "throw", "try", "typeof", "var", "void", "while", "with"];
+            properties = properties.concat(keywords);
+        }
+
         properties.sort();
 
         for (var i = 0; i < properties.length; ++i) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to