Title: [223693] trunk/Source/WTF
- Revision
- 223693
- Author
- [email protected]
- Date
- 2017-10-19 11:18:32 -0700 (Thu, 19 Oct 2017)
Log Message
REGRESSION (r223476): WebCore exports symbols with names belonging to other frameworks
https://bugs.webkit.org/show_bug.cgi?id=178424
Reviewed by David Kilzer.
This patch moves the wrapper function sharing the name of the externed function
to the source file and marks it as always inline. Marking it as inline prevents
the framework from exporting it.
* wtf/cocoa/SoftLinking.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (223692 => 223693)
--- trunk/Source/WTF/ChangeLog 2017-10-19 17:58:21 UTC (rev 223692)
+++ trunk/Source/WTF/ChangeLog 2017-10-19 18:18:32 UTC (rev 223693)
@@ -1,3 +1,16 @@
+2017-10-19 Keith Miller <[email protected]>
+
+ REGRESSION (r223476): WebCore exports symbols with names belonging to other frameworks
+ https://bugs.webkit.org/show_bug.cgi?id=178424
+
+ Reviewed by David Kilzer.
+
+ This patch moves the wrapper function sharing the name of the externed function
+ to the source file and marks it as always inline. Marking it as inline prevents
+ the framework from exporting it.
+
+ * wtf/cocoa/SoftLinking.h:
+
2017-10-18 Keith Miller <[email protected]>
Setup WebCore build to start using unified sources.
Modified: trunk/Source/WTF/wtf/cocoa/SoftLinking.h (223692 => 223693)
--- trunk/Source/WTF/wtf/cocoa/SoftLinking.h 2017-10-19 17:58:21 UTC (rev 223692)
+++ trunk/Source/WTF/wtf/cocoa/SoftLinking.h 2017-10-19 18:18:32 UTC (rev 223693)
@@ -476,6 +476,10 @@
{ \
return softLink##framework##functionName parameterNames; \
} \
+ } \
+ ALWAYS_INLINE resultType functionName parameterDeclarations \
+ {\
+ return functionNamespace::softLink##framework##functionName parameterNames; \
}
#define SOFT_LINK_FUNCTION_FOR_SOURCE(functionNamespace, framework, functionName, resultType, parameterDeclarations, parameterNames) \
@@ -494,10 +498,6 @@
}); \
return softLink##framework##functionName parameterNames; \
} \
- } \
- resultType functionName parameterDeclarations \
- {\
- return functionNamespace::softLink##framework##functionName parameterNames; \
}
#define SOFT_LINK_FUNCTION_MAY_FAIL_FOR_HEADER(functionNamespace, framework, functionName, resultType, parameterDeclarations, parameterNames) \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
