Title: [223694] trunk/Source/WebInspectorUI
Revision
223694
Author
[email protected]
Date
2017-10-19 11:33:10 -0700 (Thu, 19 Oct 2017)

Log Message

[GTK] Inspector UI does not use system font despite -webkit-system-font being supported
https://bugs.webkit.org/show_bug.cgi?id=178388

Reviewed by Joseph Pecoraro.

Change ocurrences of the "-apple-system" generic font name to
"-webkit-system-font", which is also implemented by the GTK+ port.

* UserInterface/Views/CodeMirrorOverrides.css:
(.CodeMirror .CodeMirror-linenumber):
(.CodeMirror .CodeMirror-placeholder):
* UserInterface/Views/ConsoleMessageView.css:
(.console-user-command.special-user-log > .console-message-text):
(.console-message .console-message-extra-parameters-container > li::before):
(.console-message .console-message-location):
* UserInterface/Views/DataGrid.css:
(.data-grid td):
* UserInterface/Views/DefaultDashboardView.css:
(.toolbar .dashboard.default > .item):
* UserInterface/Views/HeapSnapshotInstancesContentView.css:
(.heap-snapshot-instance-popover-content > .title):
* UserInterface/Views/HierarchicalPathComponent.css:
(.hierarchical-path-component):
* UserInterface/Views/LogContentView.css:
(.console-messages):
* UserInterface/Views/Main.css:
(body):
* UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
(.object-tree-array-index .index-name):
* UserInterface/Views/ObjectTreePropertyTreeElement.css:
(.object-tree-property .property-name,):
* UserInterface/Views/ObjectTreeView.css:
(.tree-outline.object li .empty-message):
* UserInterface/Views/RecordingActionTreeElement.css:
(.item.action:not(.initial-state)::before):
* UserInterface/Views/SourceCodeTextEditor.css:
(.source-code.text-editor > .CodeMirror .line-indicator-widget > .text):
(.popover .debugger-popover-content > .title):
* UserInterface/Views/TypeTreeView.css:
(.type-tree):
* UserInterface/Views/VisualStyleFontFamilyTreeElement.js:

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (223693 => 223694)


--- trunk/Source/WebInspectorUI/ChangeLog	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-10-19 18:33:10 UTC (rev 223694)
@@ -1,3 +1,47 @@
+2017-10-19  Adrian Perez de Castro  <[email protected]>
+
+        [GTK] Inspector UI does not use system font despite -webkit-system-font being supported
+        https://bugs.webkit.org/show_bug.cgi?id=178388
+
+        Reviewed by Joseph Pecoraro.
+
+        Change ocurrences of the "-apple-system" generic font name to
+        "-webkit-system-font", which is also implemented by the GTK+ port.
+
+        * UserInterface/Views/CodeMirrorOverrides.css:
+        (.CodeMirror .CodeMirror-linenumber):
+        (.CodeMirror .CodeMirror-placeholder):
+        * UserInterface/Views/ConsoleMessageView.css:
+        (.console-user-command.special-user-log > .console-message-text):
+        (.console-message .console-message-extra-parameters-container > li::before):
+        (.console-message .console-message-location):
+        * UserInterface/Views/DataGrid.css:
+        (.data-grid td):
+        * UserInterface/Views/DefaultDashboardView.css:
+        (.toolbar .dashboard.default > .item):
+        * UserInterface/Views/HeapSnapshotInstancesContentView.css:
+        (.heap-snapshot-instance-popover-content > .title):
+        * UserInterface/Views/HierarchicalPathComponent.css:
+        (.hierarchical-path-component):
+        * UserInterface/Views/LogContentView.css:
+        (.console-messages):
+        * UserInterface/Views/Main.css:
+        (body):
+        * UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
+        (.object-tree-array-index .index-name):
+        * UserInterface/Views/ObjectTreePropertyTreeElement.css:
+        (.object-tree-property .property-name,):
+        * UserInterface/Views/ObjectTreeView.css:
+        (.tree-outline.object li .empty-message):
+        * UserInterface/Views/RecordingActionTreeElement.css:
+        (.item.action:not(.initial-state)::before):
+        * UserInterface/Views/SourceCodeTextEditor.css:
+        (.source-code.text-editor > .CodeMirror .line-indicator-widget > .text):
+        (.popover .debugger-popover-content > .title):
+        * UserInterface/Views/TypeTreeView.css:
+        (.type-tree):
+        * UserInterface/Views/VisualStyleFontFamilyTreeElement.js:
+
 2017-10-18  Ross Kirsling  <[email protected]>
 
         Web Inspector: Layers sidebar footer should not have white background with full-width quick console

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorOverrides.css (223693 => 223694)


--- trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorOverrides.css	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorOverrides.css	2017-10-19 18:33:10 UTC (rev 223694)
@@ -76,7 +76,7 @@
 
     color: hsl(0, 0%, 57%);
 
-    font: 8px/13px -apple-system, Menlo, Monaco, monospace;
+    font: 8px/13px -webkit-system-font, Menlo, Monaco, monospace;
     font-variant-numeric: tabular-nums;
     text-align: right;
 }
@@ -86,7 +86,7 @@
 }
 
 .CodeMirror .CodeMirror-placeholder {
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
     color: hsl(0, 0%, 65%);
     text-indent: 0;
 }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css (223693 => 223694)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css	2017-10-19 18:33:10 UTC (rev 223694)
@@ -35,7 +35,7 @@
     border: 1px solid transparent;
     background-color: var(--selected-background-color);
     color: var(--selected-foreground-color);
-    font: 10px -apple-system, sans-serif;
+    font: 10px -webkit-system-font, sans-serif;
     -webkit-user-select: none;
 }
 
@@ -144,7 +144,7 @@
     height: 13px;
     content: "•";
 
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
     font-size: 11px;
     color: var(--console-secondary-text-color);
 
@@ -235,7 +235,7 @@
 
 .console-message .console-message-location {
     float: right;
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
     font-size: 12px;
     font-weight: normal;
 }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css (223693 => 223694)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css	2017-10-19 18:33:10 UTC (rev 223694)
@@ -178,7 +178,7 @@
     padding: 2px 6px;
     white-space: nowrap;
     overflow: hidden;
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
     font-variant-numeric: tabular-nums;
 }
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css (223693 => 223694)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css	2017-10-19 18:33:10 UTC (rev 223694)
@@ -53,7 +53,7 @@
     border-radius: 4px;
     border: 1px solid transparent;
 
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
     font-variant-numeric: tabular-nums;
 }
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstancesContentView.css (223693 => 223694)


--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstancesContentView.css	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstancesContentView.css	2017-10-19 18:33:10 UTC (rev 223694)
@@ -138,7 +138,7 @@
 }
 
 .heap-snapshot-instance-popover-content > .title {
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
     text-align: center;
     border-bottom: 1px solid var(--border-color);
     padding: 0 5px 2px 5px;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css (223693 => 223694)


--- trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css	2017-10-19 18:33:10 UTC (rev 223694)
@@ -30,7 +30,7 @@
     min-width: 32px;
 
     font-size: 11px;
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
 
     --path-component-icon-margin-start: 4px;
     --path-component-icon-margin-end: 3px;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (223693 => 223694)


--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2017-10-19 18:33:10 UTC (rev 223694)
@@ -81,7 +81,7 @@
 
     word-wrap: break-word;
 
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
     font-size: 12px;
 
     min-height: 100%;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Main.css (223693 => 223694)


--- trunk/Source/WebInspectorUI/UserInterface/Views/Main.css	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Main.css	2017-10-19 18:33:10 UTC (rev 223694)
@@ -28,7 +28,7 @@
 }
 
 body {
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
     font-size: 11px;
 
     position: absolute;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css (223693 => 223694)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css	2017-10-19 18:33:10 UTC (rev 223694)
@@ -35,7 +35,7 @@
 }
 
 .object-tree-array-index .index-name {
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
     font-size: 11px;
     font-variant-numeric: tabular-nums;
     vertical-align: top;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css (223693 => 223694)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css	2017-10-19 18:33:10 UTC (rev 223694)
@@ -76,7 +76,7 @@
 .object-tree-property .property-name,
 .object-tree-property .function-parameters,
 .object-tree-property .prototype-name {
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
     font-size: 12px;
 }
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css (223693 => 223694)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css	2017-10-19 18:33:10 UTC (rev 223694)
@@ -121,7 +121,7 @@
 .tree-outline.object li .empty-message {
     color: hsl(0, 0%, 60%);
     margin-left: 15px;
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
     font-size: 12px;
 }
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.css (223693 => 223694)


--- trunk/Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.css	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.css	2017-10-19 18:33:10 UTC (rev 223694)
@@ -35,7 +35,7 @@
     position: relative;
     top: 3px;
     content: attr(data-index);
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
     font-size: 9px;
     color: var(--text-color-gray-medium);
     font-variant-numeric: tabular-nums;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css (223693 => 223694)


--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css	2017-10-19 18:33:10 UTC (rev 223694)
@@ -90,7 +90,7 @@
 }
 
 .source-code.text-editor > .CodeMirror .line-indicator-widget > .text {
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
 }
 
 .source-code.text-editor > .CodeMirror .line-indicator-widget.inline > .text {
@@ -160,7 +160,7 @@
 }
 
 .popover .debugger-popover-content > .title {
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
     font-weight: 500;
 
     padding: 2px 6px 4px 6px;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css (223693 => 223694)


--- trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css	2017-10-19 18:33:10 UTC (rev 223694)
@@ -28,7 +28,7 @@
     display: block;
 
     color: black;
-    font-family: -apple-system, sans-serif;
+    font-family: -webkit-system-font, sans-serif;
     font-size: 12px;
 }
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleFontFamilyTreeElement.js (223693 => 223694)


--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleFontFamilyTreeElement.js	2017-10-19 18:18:32 UTC (rev 223693)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleFontFamilyTreeElement.js	2017-10-19 18:33:10 UTC (rev 223694)
@@ -166,7 +166,7 @@
     }
 };
 
-WI.VisualStyleFontFamilyTreeElement.FontFamilyFallback = "-apple-system, sans-serif";
+WI.VisualStyleFontFamilyTreeElement.FontFamilyFallback = "-webkit-system-font, sans-serif";
 
 WI.VisualStyleFontFamilyTreeElement.Event = {
     KeywordChanged: "visual-style-font-family-tree-element-keyword-changed",
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to