Title: [228585] trunk
- Revision
- 228585
- Author
- [email protected]
- Date
- 2018-02-16 15:15:08 -0800 (Fri, 16 Feb 2018)
Log Message
Assert in mixed blend animation
https://bugs.webkit.org/show_bug.cgi?id=182887
<rdar://problem/37598140>
Reviewed by Zalan Bujtas.
Test: fast/css/calc-mixed-blend-crash.html
* platform/CalculationValue.cpp:
(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):
Fix mismatch between the type test and the value used.
Modified Paths
Added Paths
Diff
Added: trunk/LayoutTests/fast/css/calc-mixed-blend-crash-expected.txt (0 => 228585)
--- trunk/LayoutTests/fast/css/calc-mixed-blend-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/calc-mixed-blend-crash-expected.txt 2018-02-16 23:15:08 UTC (rev 228585)
@@ -0,0 +1 @@
+This test passes if it doesn't crash.
Added: trunk/LayoutTests/fast/css/calc-mixed-blend-crash.html (0 => 228585)
--- trunk/LayoutTests/fast/css/calc-mixed-blend-crash.html (rev 0)
+++ trunk/LayoutTests/fast/css/calc-mixed-blend-crash.html 2018-02-16 23:15:08 UTC (rev 228585)
@@ -0,0 +1,27 @@
+<html>
+<div id="targetElem"></div>
+This test passes if it doesn't crash.
+<script>
+if (window.testRunner)
+ testRunner.dumpAsText();
+var head = document.getElementsByTagName("head")[0];
+var style = document.createElement("style");
+style.innerHTML=`* {
+position: inherit;
+-webkit-animation-name: name;
+-webkit-animation-duration: 0.1s;
+-webkit-animation-direction: alternate;
+}
+@-webkit-keyframes name {
+ from {
+ word-spacing: 5;
+ }
+ to {
+ word-spacing: 10%;
+ }
+}
+`;
+head.appendChild(style);
+document.getElementById("targetElem").style.WebkitTransitionDuration="1s";
+</script>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (228584 => 228585)
--- trunk/Source/WebCore/ChangeLog 2018-02-16 23:12:13 UTC (rev 228584)
+++ trunk/Source/WebCore/ChangeLog 2018-02-16 23:15:08 UTC (rev 228585)
@@ -1,3 +1,18 @@
+2018-02-16 Antti Koivisto <[email protected]>
+
+ Assert in mixed blend animation
+ https://bugs.webkit.org/show_bug.cgi?id=182887
+ <rdar://problem/37598140>
+
+ Reviewed by Zalan Bujtas.
+
+ Test: fast/css/calc-mixed-blend-crash.html
+
+ * platform/CalculationValue.cpp:
+ (WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):
+
+ Fix mismatch between the type test and the value used.
+
2018-02-16 Zalan Bujtas <[email protected]>
[RenderTreeBuilder] Move RenderBlock/RenderInline::addChildIgnoringContinuation() to RenderTreeBuilder
Modified: trunk/Source/WebCore/platform/CalculationValue.cpp (228584 => 228585)
--- trunk/Source/WebCore/platform/CalculationValue.cpp 2018-02-16 23:12:13 UTC (rev 228584)
+++ trunk/Source/WebCore/platform/CalculationValue.cpp 2018-02-16 23:15:08 UTC (rev 228585)
@@ -178,7 +178,7 @@
if (m_from.isCalculated() && m_from.calculationValue()._expression_().type() == CalcExpressionNodeBlendLength)
m_from = toCalcExpressionBlendLength(m_from.calculationValue()._expression_()).from();
if (m_to.isCalculated() && m_to.calculationValue()._expression_().type() == CalcExpressionNodeBlendLength)
- m_to = toCalcExpressionBlendLength(m_from.calculationValue()._expression_()).to();
+ m_to = toCalcExpressionBlendLength(m_to.calculationValue()._expression_()).to();
}
float CalcExpressionBlendLength::evaluate(float maxValue) const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
