Title: [228586] trunk/Source/WebCore
- Revision
- 228586
- Author
- [email protected]
- Date
- 2018-02-16 15:18:00 -0800 (Fri, 16 Feb 2018)
Log Message
http/tests/security/http-0.9/xhr-blocked.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=182857
<rdar://problem/37616958>
Reviewed by Antti Koivisto.
WebCoreResourceHandleAsOperationQueueDelegate does not own the messageQueue and
the detachHandle function was failing to nullout m_messageQueue when the resourceHandle
gets destroyed. This means that callFunctionOnMainThread would sometimes try to append
to a dead messageQueue.
No new tests, already covered by:
http/tests/security/http-0.9/xhr-blocked.html is flaky
* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate detachHandle]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (228585 => 228586)
--- trunk/Source/WebCore/ChangeLog 2018-02-16 23:15:08 UTC (rev 228585)
+++ trunk/Source/WebCore/ChangeLog 2018-02-16 23:18:00 UTC (rev 228586)
@@ -1,3 +1,22 @@
+2018-02-16 Chris Dumez <[email protected]>
+
+ http/tests/security/http-0.9/xhr-blocked.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=182857
+ <rdar://problem/37616958>
+
+ Reviewed by Antti Koivisto.
+
+ WebCoreResourceHandleAsOperationQueueDelegate does not own the messageQueue and
+ the detachHandle function was failing to nullout m_messageQueue when the resourceHandle
+ gets destroyed. This means that callFunctionOnMainThread would sometimes try to append
+ to a dead messageQueue.
+
+ No new tests, already covered by:
+ http/tests/security/http-0.9/xhr-blocked.html is flaky
+
+ * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
+ (-[WebCoreResourceHandleAsOperationQueueDelegate detachHandle]):
+
2018-02-16 Antti Koivisto <[email protected]>
Assert in mixed blend animation
Modified: trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm (228585 => 228586)
--- trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm 2018-02-16 23:15:08 UTC (rev 228585)
+++ trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm 2018-02-16 23:18:00 UTC (rev 228586)
@@ -101,6 +101,7 @@
m_handle = nullptr;
+ m_messageQueue = nullptr;
m_requestResult = nullptr;
m_cachedResponseResult = nullptr;
m_boolResult = NO;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
