Title: [230585] trunk/Source
Revision
230585
Author
[email protected]
Date
2018-04-12 11:19:50 -0700 (Thu, 12 Apr 2018)

Log Message

[WPE] Move libWPEWebInspectorResources.so to pkglibdir
https://bugs.webkit.org/show_bug.cgi?id=184379

Reviewed by Žan Doberšek.

Source/_javascript_Core:

Load the module from the new location.

* PlatformWPE.cmake:
* inspector/remote/glib/RemoteInspectorUtils.cpp:
(Inspector::backendCommands):

Source/WebKit:

This is important to allow parallel installation.

* PlatformWPE.cmake:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (230584 => 230585)


--- trunk/Source/_javascript_Core/ChangeLog	2018-04-12 18:01:58 UTC (rev 230584)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-04-12 18:19:50 UTC (rev 230585)
@@ -1,3 +1,16 @@
+2018-04-12  Michael Catanzaro  <[email protected]>
+
+        [WPE] Move libWPEWebInspectorResources.so to pkglibdir
+        https://bugs.webkit.org/show_bug.cgi?id=184379
+
+        Reviewed by Žan Doberšek.
+
+        Load the module from the new location.
+
+        * PlatformWPE.cmake:
+        * inspector/remote/glib/RemoteInspectorUtils.cpp:
+        (Inspector::backendCommands):
+
 2018-04-12  Yusuke Suzuki  <[email protected]>
 
         [DFG] Remove compileBigIntEquality in DFG 32bit

Modified: trunk/Source/_javascript_Core/PlatformWPE.cmake (230584 => 230585)


--- trunk/Source/_javascript_Core/PlatformWPE.cmake	2018-04-12 18:01:58 UTC (rev 230584)
+++ trunk/Source/_javascript_Core/PlatformWPE.cmake	2018-04-12 18:19:50 UTC (rev 230585)
@@ -33,3 +33,4 @@
 )
 
 add_definitions(-DJSC_COMPILATION)
+add_definitions(-DPKGLIBDIR="${CMAKE_INSTALL_FULL_LIBDIR}/wpe-webkit-${WPE_API_VERSION}")

Modified: trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorUtils.cpp (230584 => 230585)


--- trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorUtils.cpp	2018-04-12 18:01:58 UTC (rev 230584)
+++ trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorUtils.cpp	2018-04-12 18:19:50 UTC (rev 230585)
@@ -45,7 +45,7 @@
 #if PLATFORM(WPE)
     static std::once_flag flag;
     std::call_once(flag, [] {
-        GModule* resourcesModule = g_module_open("libWPEWebInspectorResources.so", G_MODULE_BIND_LAZY);
+        GModule* resourcesModule = g_module_open(PKGLIBDIR G_DIR_SEPARATOR_S "libWPEWebInspectorResources.so", G_MODULE_BIND_LAZY);
         if (!resourcesModule) {
             WTFLogAlways("Error loading libWPEWebInspectorResources.so: %s", g_module_error());
             return;

Modified: trunk/Source/WebKit/ChangeLog (230584 => 230585)


--- trunk/Source/WebKit/ChangeLog	2018-04-12 18:01:58 UTC (rev 230584)
+++ trunk/Source/WebKit/ChangeLog	2018-04-12 18:19:50 UTC (rev 230585)
@@ -1,5 +1,16 @@
 2018-04-12  Michael Catanzaro  <[email protected]>
 
+        [WPE] Move libWPEWebInspectorResources.so to pkglibdir
+        https://bugs.webkit.org/show_bug.cgi?id=184379
+
+        Reviewed by Žan Doberšek.
+
+        This is important to allow parallel installation.
+
+        * PlatformWPE.cmake:
+
+2018-04-12  Michael Catanzaro  <[email protected]>
+
         [WPE] Improve include hierarchy
         https://bugs.webkit.org/show_bug.cgi?id=184376
 

Modified: trunk/Source/WebKit/PlatformWPE.cmake (230584 => 230585)


--- trunk/Source/WebKit/PlatformWPE.cmake	2018-04-12 18:01:58 UTC (rev 230584)
+++ trunk/Source/WebKit/PlatformWPE.cmake	2018-04-12 18:19:50 UTC (rev 230585)
@@ -313,7 +313,7 @@
 add_dependencies(WPEWebInspectorResources WebKit)
 target_link_libraries(WPEWebInspectorResources ${WPEWebInspectorResources_LIBRARIES})
 target_include_directories(WPEWebInspectorResources SYSTEM PUBLIC ${WPEWebInspectorResources_SYSTEM_INCLUDE_DIRECTORIES})
-install(TARGETS WPEWebInspectorResources DESTINATION "${LIB_INSTALL_DIR}")
+install(TARGETS WPEWebInspectorResources DESTINATION "${LIB_INSTALL_DIR}/wpe-webkit-${WPE_API_VERSION}")
 
 add_library(WPEInjectedBundle MODULE "${WEBKIT_DIR}/WebProcess/InjectedBundle/API/glib/WebKitInjectedBundleMain.cpp")
 ADD_WEBKIT_PREFIX_HEADER(WPEInjectedBundle)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to