Diff
Modified: trunk/ChangeLog (230585 => 230586)
--- trunk/ChangeLog 2018-04-12 18:19:50 UTC (rev 230585)
+++ trunk/ChangeLog 2018-04-12 18:32:26 UTC (rev 230586)
@@ -1,3 +1,16 @@
+2018-04-12 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r230554.
+
+ The non-ASCII character in the filename causes issues with SVN
+
+ Reverted changeset:
+
+ "input.webkitEntries does not work as expected when folder
+ contains accented chars"
+ https://bugs.webkit.org/show_bug.cgi?id=184517
+ https://trac.webkit.org/changeset/230554
+
2018-04-12 Zan Dobersek <[email protected]>
[WPE] Switch testing process to using WPEBackend-fdo
Modified: trunk/LayoutTests/ChangeLog (230585 => 230586)
--- trunk/LayoutTests/ChangeLog 2018-04-12 18:19:50 UTC (rev 230585)
+++ trunk/LayoutTests/ChangeLog 2018-04-12 18:32:26 UTC (rev 230586)
@@ -1,3 +1,16 @@
+2018-04-12 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r230554.
+
+ The non-ASCII character in the filename causes issues with SVN
+
+ Reverted changeset:
+
+ "input.webkitEntries does not work as expected when folder
+ contains accented chars"
+ https://bugs.webkit.org/show_bug.cgi?id=184517
+ https://trac.webkit.org/changeset/230554
+
2018-04-12 Antoine Quint <[email protected]>
[Web Animations] Suspend animations when required
Deleted: trunk/LayoutTests/fast/forms/file/entries-api/webkitEntries-nonascii-folder-name-expected.txt (230585 => 230586)
--- trunk/LayoutTests/fast/forms/file/entries-api/webkitEntries-nonascii-folder-name-expected.txt 2018-04-12 18:19:50 UTC (rev 230585)
+++ trunk/LayoutTests/fast/forms/file/entries-api/webkitEntries-nonascii-folder-name-expected.txt 2018-04-12 18:32:26 UTC (rev 230586)
@@ -1,15 +0,0 @@
-OPEN FILE PANEL
-Tests webkitEntries when the path includes a folder with a non-ascii character in its name.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS entries.length is 1
-PASS entry.name is "test.txt"
-PASS entry.fullPath is "/test.txt"
-PASS entry.isFile is true
-PASS contentResult is "TEST\n"
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html (230585 => 230586)
--- trunk/LayoutTests/fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html 2018-04-12 18:19:50 UTC (rev 230585)
+++ trunk/LayoutTests/fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html 2018-04-12 18:32:26 UTC (rev 230586)
@@ -1,75 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<meta charset="UTF-8">
-<script src=""
-<script src=""
-</head>
-<body>
-<input type="file" _onchange_="changed(event)">
-<script>
-description("Tests webkitEntries when the path includes a folder with a non-ascii character in its name.");
-jsTestIsAsync = true;
-
-function runTest()
-{
- testRunner.setOpenPanelFiles(['resources/älo/test.txt']);
-
- inputElement = document.getElementsByTagName('input')[0];
- UIHelper.activateAt(inputElement.offsetLeft + inputElement.offsetWidth / 2, inputElement.offsetTop + inputElement.offsetHeight / 2);
-}
-
-function fileAsPromise(fileEntry)
-{
- return new Promise((resolve, reject) => {
- fileEntry.file(resolve, reject);
- });
-}
-
-function readTextFileAsPromise(file)
-{
- return new Promise((resolve, reject) => {
- let fileReader = new FileReader();
- fileReader._onload_ = function(e) {
- resolve(fileReader.result);
- }
- fileReader.readAsText(file);
- });
-}
-
-function getFileAsPromise(directoryEntry, path)
-{
- return new Promise((resolve, reject) => {
- directoryEntry.getFile(path, {}, resolve, reject);
- });
-}
-
-function changed(event)
-{
- entries = event.target.webkitEntries;
- shouldBe("entries.length", "1");
-
- entry = entries[0];
- shouldBeEqualToString("entry.name", "test.txt");
- shouldBeEqualToString("entry.fullPath", "/test.txt");
- shouldBeTrue("entry.isFile");
-
- fileAsPromise(entry).then(file => {
- return readTextFileAsPromise(file).then(content => {
- contentResult = content;
- shouldBeEqualToString("contentResult", "TEST\n");
- finishJSTest();
- }, e => {
- testFailed("Reading file contents failed unexpectedly: " + e);
- finishJSTest();
- });
- }, e => {
- testFailed("fileEntry.file() call failed unexpectedly: " + e);
- finishJSTest();
- });
-}
-
-runTest();
-</script>
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (230585 => 230586)
--- trunk/Source/WebCore/ChangeLog 2018-04-12 18:19:50 UTC (rev 230585)
+++ trunk/Source/WebCore/ChangeLog 2018-04-12 18:32:26 UTC (rev 230586)
@@ -1,3 +1,16 @@
+2018-04-12 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r230554.
+
+ The non-ASCII character in the filename causes issues with SVN
+
+ Reverted changeset:
+
+ "input.webkitEntries does not work as expected when folder
+ contains accented chars"
+ https://bugs.webkit.org/show_bug.cgi?id=184517
+ https://trac.webkit.org/changeset/230554
+
2018-04-12 Alicia Boya García <[email protected]>
[MSE] Add isValid() assertions on PlatformTimeRanges::add() range ends
Modified: trunk/Source/WebCore/platform/posix/FileSystemPOSIX.cpp (230585 => 230586)
--- trunk/Source/WebCore/platform/posix/FileSystemPOSIX.cpp 2018-04-12 18:19:50 UTC (rev 230585)
+++ trunk/Source/WebCore/platform/posix/FileSystemPOSIX.cpp 2018-04-12 18:32:26 UTC (rev 230586)
@@ -351,7 +351,7 @@
if (!fsRep.data() || fsRep.data()[0] == '\0')
return String();
- return String::fromUTF8(dirname(fsRep.mutableData()));
+ return dirname(fsRep.mutableData());
}
Vector<String> listDirectory(const String& path, const String& filter)
