Title: [101007] trunk/Source/WebCore
- Revision
- 101007
- Author
- commit-qu...@webkit.org
- Date
- 2011-11-22 09:39:54 -0800 (Tue, 22 Nov 2011)
Log Message
CSSStyleDeclaration: Kill FIXME in setProperty().
<http://webkit.org/b/72958>
Patch by Andreas Kling <kl...@webkit.org> on 2011-11-22
Reviewed by Antonio Gomes.
Remove FIXME about possibly throwing an exception when setProperty()
is called with an invalid property name. CSSOM specifies that the
method should simply return in this case.
Spec: http://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-setproperty
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::setProperty):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (101006 => 101007)
--- trunk/Source/WebCore/ChangeLog 2011-11-22 17:03:17 UTC (rev 101006)
+++ trunk/Source/WebCore/ChangeLog 2011-11-22 17:39:54 UTC (rev 101007)
@@ -1,3 +1,19 @@
+2011-11-22 Andreas Kling <kl...@webkit.org>
+
+ CSSStyleDeclaration: Kill FIXME in setProperty().
+ <http://webkit.org/b/72958>
+
+ Reviewed by Antonio Gomes.
+
+ Remove FIXME about possibly throwing an exception when setProperty()
+ is called with an invalid property name. CSSOM specifies that the
+ method should simply return in this case.
+
+ Spec: http://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-setproperty
+
+ * css/CSSStyleDeclaration.cpp:
+ (WebCore::CSSStyleDeclaration::setProperty):
+
2011-11-22 Shinya Kawanaka <shin...@google.com>
Spellcheck should be able to run asynchronously.
Modified: trunk/Source/WebCore/css/CSSStyleDeclaration.cpp (101006 => 101007)
--- trunk/Source/WebCore/css/CSSStyleDeclaration.cpp 2011-11-22 17:03:17 UTC (rev 101006)
+++ trunk/Source/WebCore/css/CSSStyleDeclaration.cpp 2011-11-22 17:39:54 UTC (rev 101007)
@@ -107,10 +107,8 @@
void CSSStyleDeclaration::setProperty(const String& propertyName, const String& value, const String& priority, ExceptionCode& ec)
{
int propID = cssPropertyID(propertyName);
- if (!propID) {
- // FIXME: Should we raise an exception here?
+ if (!propID)
return;
- }
bool important = priority.find("important", 0, false) != notFound;
setProperty(propID, value, important, ec);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
