Title: [101008] trunk/Source/WebCore
- Revision
- 101008
- Author
- commit-qu...@webkit.org
- Date
- 2011-11-22 09:42:42 -0800 (Tue, 22 Nov 2011)
Log Message
CSSProperty: Remove unnecessary operator overloads.
<http://webkit.org/b/72953>
Patch by Andreas Kling <kl...@webkit.org> on 2011-11-22
Reviewed by Antti Koivisto.
* css/CSSProperty.cpp:
* css/CSSProperty.h:
Remove operator= and operator== from CSSProperty. They were neither
implemented correctly nor used anywhere.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (101007 => 101008)
--- trunk/Source/WebCore/ChangeLog 2011-11-22 17:39:54 UTC (rev 101007)
+++ trunk/Source/WebCore/ChangeLog 2011-11-22 17:42:42 UTC (rev 101008)
@@ -1,5 +1,18 @@
2011-11-22 Andreas Kling <kl...@webkit.org>
+ CSSProperty: Remove unnecessary operator overloads.
+ <http://webkit.org/b/72953>
+
+ Reviewed by Antti Koivisto.
+
+ * css/CSSProperty.cpp:
+ * css/CSSProperty.h:
+
+ Remove operator= and operator== from CSSProperty. They were neither
+ implemented correctly nor used anywhere.
+
+2011-11-22 Andreas Kling <kl...@webkit.org>
+
CSSStyleDeclaration: Kill FIXME in setProperty().
<http://webkit.org/b/72958>
Modified: trunk/Source/WebCore/css/CSSProperty.cpp (101007 => 101008)
--- trunk/Source/WebCore/css/CSSProperty.cpp 2011-11-22 17:39:54 UTC (rev 101007)
+++ trunk/Source/WebCore/css/CSSProperty.cpp 2011-11-22 17:42:42 UTC (rev 101008)
@@ -32,11 +32,6 @@
return String(getPropertyName(static_cast<CSSPropertyID>(id()))) + ": " + m_value->cssText() + (isImportant() ? " !important" : "") + "; ";
}
-bool operator==(const CSSProperty& a, const CSSProperty& b)
-{
- return a.m_id == b.m_id && a.m_important == b.m_important && a.m_value == b.m_value;
-}
-
enum LogicalBoxSide { BeforeSide, EndSide, AfterSide, StartSide };
enum PhysicalBoxSide { TopSide, RightSide, BottomSide, LeftSide };
Modified: trunk/Source/WebCore/css/CSSProperty.h (101007 => 101008)
--- trunk/Source/WebCore/css/CSSProperty.h 2011-11-22 17:39:54 UTC (rev 101007)
+++ trunk/Source/WebCore/css/CSSProperty.h 2011-11-22 17:42:42 UTC (rev 101008)
@@ -42,16 +42,6 @@
{
}
- CSSProperty& operator=(const CSSProperty& other)
- {
- m_id = other.m_id;
- m_shorthandID = other.m_shorthandID;
- m_important = other.m_important;
- m_implicit = other.m_implicit;
- m_value = other.m_value;
- return *this;
- }
-
int id() const { return m_id; }
int shorthandID() const { return m_shorthandID; }
@@ -66,8 +56,6 @@
static int resolveDirectionAwareProperty(int propertyID, TextDirection, WritingMode);
static bool isInheritedProperty(unsigned propertyID);
- friend bool operator==(const CSSProperty&, const CSSProperty&);
-
// Make sure the following fits in 4 bytes. Really.
unsigned m_id : 14;
unsigned m_shorthandID : 14; // If this property was set as part of a shorthand, gives the shorthand.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
