Title: [250813] trunk/Source/WebInspectorUI
- Revision
- 250813
- Author
- drou...@apple.com
- Date
- 2019-10-07 21:34:53 -0700 (Mon, 07 Oct 2019)
Log Message
Web Inspector: Debugger: don't allow blackboxing of scripts that aren't finished loading or failed to load
https://bugs.webkit.org/show_bug.cgi?id=202376
Reviewed by Matt Baker.
* UserInterface/Models/Resource.js:
(WI.Resource.prototype.get supportsScriptBlackboxing):
* UserInterface/Views/SourceCodeTreeElement.js:
(WI.SourceCodeTreeElement.prototype.updateStatus):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (250812 => 250813)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-10-08 02:45:22 UTC (rev 250812)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-10-08 04:34:53 UTC (rev 250813)
@@ -1,3 +1,16 @@
+2019-10-07 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: Debugger: don't allow blackboxing of scripts that aren't finished loading or failed to load
+ https://bugs.webkit.org/show_bug.cgi?id=202376
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Models/Resource.js:
+ (WI.Resource.prototype.get supportsScriptBlackboxing):
+
+ * UserInterface/Views/SourceCodeTreeElement.js:
+ (WI.SourceCodeTreeElement.prototype.updateStatus):
+
2019-10-02 Nikita Vasilyev <nvasil...@apple.com>
Web Inspector: Styles: for rules that don't match selected node, property values always show as invalid
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js (250812 => 250813)
--- trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js 2019-10-08 02:45:22 UTC (rev 250812)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js 2019-10-08 04:34:53 UTC (rev 250813)
@@ -373,6 +373,8 @@
{
if (this.isLocalResourceOverride)
return false;
+ if (!this.finished || this.failed)
+ return false;
return super.supportsScriptBlackboxing;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js (250812 => 250813)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js 2019-10-08 02:45:22 UTC (rev 250812)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js 2019-10-08 04:34:53 UTC (rev 250813)
@@ -168,7 +168,8 @@
this.status = this._toggleBlackboxedImageElement;
this._updateToggleBlackboxImageElementState();
- }
+ } else if (this.status === this._toggleBlackboxedImageElement)
+ this.status = null;
}
// Protected (ResourceTreeElement calls this when its Resource changes dynamically for Frames)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
