Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (250813 => 250814)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-10-08 04:34:53 UTC (rev 250813)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-10-08 04:50:03 UTC (rev 250814)
@@ -1,5 +1,32 @@
2019-10-07 Devin Rousso <drou...@apple.com>
+ Web Inspector: Settings: enable the image transparency grid by default and create a checkbox for it
+ https://bugs.webkit.org/show_bug.cgi?id=202678
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Base/Setting.js:
+ Enable the "Show transparency grid" setting by default.
+
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createSourcesSettingsView):
+ Add a checkbox for "Show transparency grid" in the "Sources" pane.
+
+ * UserInterface/Views/CanvasContentView.js:
+ (WI.CanvasContentView):
+ * UserInterface/Views/CanvasOverviewContentView.js:
+ (WI.CanvasOverviewContentView):
+ * UserInterface/Views/ImageResourceContentView.js:
+ (WI.ImageResourceContentView):
+ * UserInterface/Views/RecordingContentView.js:
+ (WI.RecordingContentView):
+ * UserInterface/Views/ResourceCollectionContentView.js:
+ (WI.ResourceCollectionContentView):
+ * Localizations/en.lproj/localizedStrings.js:
+ Unify the tooltip string for all of the "Show transparency grid" navigation items.
+
+2019-10-07 Devin Rousso <drou...@apple.com>
+
Web Inspector: Debugger: don't allow blackboxing of scripts that aren't finished loading or failed to load
https://bugs.webkit.org/show_bug.cgi?id=202376
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (250813 => 250814)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-10-08 04:34:53 UTC (rev 250813)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-10-08 04:50:03 UTC (rev 250814)
@@ -466,7 +466,6 @@
localizedStrings["Ensure that values for \u0022%s\u0022 are valid."] = "Ensure that values for \u0022%s\u0022 are valid.";
localizedStrings["Entered Full-Screen Mode"] = "Entered Full-Screen Mode";
localizedStrings["Entire Recording"] = "Entire Recording";
-localizedStrings["Entry point: "] = "Entry point: ";
localizedStrings["Error"] = "Error";
localizedStrings["Error: "] = "Error: ";
localizedStrings["Errors"] = "Errors";
@@ -579,7 +578,6 @@
localizedStrings["Hide Console"] = "Hide Console";
localizedStrings["Hide Console (%s)"] = "Hide Console (%s)";
localizedStrings["Hide Elements"] = "Hide Elements";
-localizedStrings["Hide Grid"] = "Hide Grid";
localizedStrings["Hide Path"] = "Hide Path";
localizedStrings["Hide compositing borders"] = "Hide compositing borders";
localizedStrings["Hide rulers"] = "Hide rulers";
@@ -586,6 +584,7 @@
localizedStrings["Hide shadow DOM nodes"] = "Hide shadow DOM nodes";
localizedStrings["Hide the details sidebar (%s)"] = "Hide the details sidebar (%s)";
localizedStrings["Hide the navigation sidebar (%s)"] = "Hide the navigation sidebar (%s)";
+localizedStrings["Hide transparency grid"] = "Hide transparency grid";
localizedStrings["Hide type information"] = "Hide type information";
localizedStrings["Hierarchy Level"] = "Hierarchy Level";
localizedStrings["High"] = "High";
@@ -603,6 +602,7 @@
localizedStrings["Image"] = "Image";
localizedStrings["Image Size"] = "Image Size";
localizedStrings["Images"] = "Images";
+localizedStrings["Images:"] = "Images:";
localizedStrings["Immediate Pause Requested"] = "Immediate Pause Requested";
localizedStrings["Import"] = "Import";
localizedStrings["Imported"] = "Imported";
@@ -1014,7 +1014,6 @@
localizedStrings["Show Console"] = "Show Console";
localizedStrings["Show Console tab"] = "Show Console tab";
localizedStrings["Show Elements"] = "Show Elements";
-localizedStrings["Show Grid"] = "Show Grid";
localizedStrings["Show Icons"] = "Show Icons";
localizedStrings["Show Jump to Effective Property Button"] = "Show Jump to Effective Property Button";
localizedStrings["Show Path"] = "Show Path";
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (250813 => 250814)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2019-10-08 04:34:53 UTC (rev 250813)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2019-10-08 04:50:03 UTC (rev 250814)
@@ -171,7 +171,7 @@
showAllTimeoutsBreakpoint: new WI.Setting("show-all-timeouts-breakpoint", false),
showAssertionFailuresBreakpoint: new WI.Setting("show-assertion-failures-breakpoint", true),
showCanvasPath: new WI.Setting("show-canvas-path", false),
- showImageGrid: new WI.Setting("show-image-grid", false),
+ showImageGrid: new WI.Setting("show-image-grid", true),
showInvisibleCharacters: new WI.Setting("show-invisible-characters", !!WI.Setting.migrateValue("show-invalid-characters")),
showJavaScriptTypeInformation: new WI.Setting("show-_javascript_-type-information", false),
showPaintRects: new WI.Setting("show-paint-rects", false),
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js (250813 => 250814)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js 2019-10-08 04:34:53 UTC (rev 250813)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js 2019-10-08 04:50:03 UTC (rev 250814)
@@ -47,7 +47,7 @@
this._refreshButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._refreshButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this.refreshPreview, this);
- this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show Grid"), WI.UIString("Hide Grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+ this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._showGridButtonClicked, this);
this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._showGridButtonNavigationItem.activated = !!WI.settings.showImageGrid.value;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js (250813 => 250814)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js 2019-10-08 04:34:53 UTC (rev 250813)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js 2019-10-08 04:50:03 UTC (rev 250814)
@@ -70,7 +70,7 @@
this._refreshButtonNavigationItem.enabled = false;
this._refreshButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._refreshPreviews, this);
- this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid"), WI.UIString("Hide Grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+ this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
this._showGridButtonNavigationItem.activated = !!WI.settings.showImageGrid.value;
this._showGridButtonNavigationItem.enabled = false;
this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._showGridButtonClicked, this);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js (250813 => 250814)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js 2019-10-08 04:34:53 UTC (rev 250813)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js 2019-10-08 04:50:03 UTC (rev 250814)
@@ -31,8 +31,8 @@
this._imageElement = null;
- const toolTip = WI.UIString("Show Grid");
- const activatedToolTip = WI.UIString("Hide Grid");
+ const toolTip = WI.UIString("Show transparency grid");
+ const activatedToolTip = WI.UIString("Hide transparency grid");
this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", toolTip, activatedToolTip, "Images/NavigationItemCheckers.svg", 13, 13);
this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._showGridButtonClicked, this);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js (250813 => 250814)
--- trunk/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js 2019-10-08 04:34:53 UTC (rev 250813)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js 2019-10-08 04:50:03 UTC (rev 250814)
@@ -58,7 +58,7 @@
this._showPathButtonNavigationItem.activated = !!WI.settings.showCanvasPath.value;
}
- this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show Grid"), WI.UIString("Hide Grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+ this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._showGridButtonClicked, this);
this._showGridButtonNavigationItem.activated = !!WI.settings.showImageGrid.value;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceCollectionContentView.js (250813 => 250814)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceCollectionContentView.js 2019-10-08 04:34:53 UTC (rev 250813)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceCollectionContentView.js 2019-10-08 04:50:03 UTC (rev 250814)
@@ -36,7 +36,7 @@
super(collection, contentViewConstructor);
if (collection.resourceType === WI.Resource.Type.Image) {
- this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show Grid"), WI.UIString("Hide Grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+ this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._handleShowGridButtonClicked, this);
this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._showGridButtonNavigationItem.activated = !!WI.settings.showImageGrid.value;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (250813 => 250814)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-10-08 04:34:53 UTC (rev 250813)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-10-08 04:50:03 UTC (rev 250814)
@@ -257,6 +257,10 @@
sourcesSettingsView.addSetting(WI.UIString("Source Maps:"), WI.settings.sourceMapsEnabled, WI.UIString("Enable source maps"));
+ sourcesSettingsView.addSeparator();
+
+ sourcesSettingsView.addSetting(WI.UIString("Images:"), WI.settings.showImageGrid, WI.UIString("Show transparency grid"));
+
this.addSettingsView(sourcesSettingsView);
}
