Title: [250989] trunk
- Revision
- 250989
- Author
- [email protected]
- Date
- 2019-10-10 14:38:55 -0700 (Thu, 10 Oct 2019)
Log Message
[Cocoa] font-family:system-ui on Chinese systems don't get Chinese quote marks
https://bugs.webkit.org/show_bug.cgi?id=202778
<rdar://problem/52594556>
Reviewed by Simon Fraser.
Source/WebCore:
This was caught by fast/text/international/system-language/han-quotes.html,
but we didn't have time to fix it until now.
Test: fast/text/international/system-language/han-quotes.html
* platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
(WebCore::SystemFontDatabaseCoreText::createSystemUIFont):
LayoutTests:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (250988 => 250989)
--- trunk/LayoutTests/ChangeLog 2019-10-10 21:20:12 UTC (rev 250988)
+++ trunk/LayoutTests/ChangeLog 2019-10-10 21:38:55 UTC (rev 250989)
@@ -1,3 +1,13 @@
+2019-10-10 Myles C. Maxfield <[email protected]>
+
+ [Cocoa] font-family:system-ui on Chinese systems don't get Chinese quote marks
+ https://bugs.webkit.org/show_bug.cgi?id=202778
+ <rdar://problem/52594556>
+
+ Reviewed by Simon Fraser.
+
+ * platform/mac/TestExpectations:
+
2019-10-10 Chris Dumez <[email protected]>
Unreviewed, tweak test to address flakiness on WK1.
Modified: trunk/LayoutTests/platform/mac/TestExpectations (250988 => 250989)
--- trunk/LayoutTests/platform/mac/TestExpectations 2019-10-10 21:20:12 UTC (rev 250988)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2019-10-10 21:38:55 UTC (rev 250989)
@@ -1977,9 +1977,6 @@
webkit.org/b/200258 [ Debug ] imported/w3c/web-platform-tests/wasm/jsapi/interface.any.worker.html [ Pass Failure ]
-# rdar://52594556 (Layout test fast/text/international/system-language/han-quotes.html is failing)
-[ Catalina+ ] fast/text/international/system-language/han-quotes.html [ ImageOnlyFailure ]
-
webkit.org/b/200128 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_timeupdate_on_seek.html [ Timeout Pass ]
# rdar://52557916 (REGRESSION: fast/css/paint-order.html and fast/css/paint-order-shadow.html are failing)
Modified: trunk/Source/WebCore/ChangeLog (250988 => 250989)
--- trunk/Source/WebCore/ChangeLog 2019-10-10 21:20:12 UTC (rev 250988)
+++ trunk/Source/WebCore/ChangeLog 2019-10-10 21:38:55 UTC (rev 250989)
@@ -1,5 +1,21 @@
2019-10-10 Myles C. Maxfield <[email protected]>
+ [Cocoa] font-family:system-ui on Chinese systems don't get Chinese quote marks
+ https://bugs.webkit.org/show_bug.cgi?id=202778
+ <rdar://problem/52594556>
+
+ Reviewed by Simon Fraser.
+
+ This was caught by fast/text/international/system-language/han-quotes.html,
+ but we didn't have time to fix it until now.
+
+ Test: fast/text/international/system-language/han-quotes.html
+
+ * platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
+ (WebCore::SystemFontDatabaseCoreText::createSystemUIFont):
+
+2019-10-10 Myles C. Maxfield <[email protected]>
+
FontFaceSet's ready promise is not always resolved
https://bugs.webkit.org/show_bug.cgi?id=202548
Modified: trunk/Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp (250988 => 250989)
--- trunk/Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp 2019-10-10 21:20:12 UTC (rev 250988)
+++ trunk/Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp 2019-10-10 21:38:55 UTC (rev 250989)
@@ -49,6 +49,8 @@
RetainPtr<CTFontRef> SystemFontDatabaseCoreText::createSystemUIFont(const CascadeListParameters& parameters, CFStringRef locale)
{
+ if (locale && !CFStringGetLength(locale))
+ locale = nullptr;
auto result = adoptCF(CTFontCreateUIFontForLanguage(kCTFontUIFontSystem, parameters.size, locale));
ASSERT(result);
return createFontByApplyingWeightItalicsAndFallbackBehavior(result.get(), parameters.weight, parameters.italic, parameters.size, parameters.allowUserInstalledFonts);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
