Title: [250990] trunk/Source/WebCore
Revision
250990
Author
[email protected]
Date
2019-10-10 14:56:16 -0700 (Thu, 10 Oct 2019)

Log Message

[Catalina] LayoutTest fast/canvas/webgl/texImage2D-mse-flip-{true,false}.html failing
https://bugs.webkit.org/show_bug.cgi?id=202771
<rdar://problem/49441298>

Reviewed by Eric Carlson.

Catalina no longer creates IOSurface-backed CVPixelBuffers by default for certain
codecs; make the CVPixelBuffers generated by WebCoreDecompressionSession IOSurface-backed
explicitly by passing in the correct attributes when creating the VTDecompressionSession.

* platform/graphics/cocoa/WebCoreDecompressionSession.mm:
(WebCore::WebCoreDecompressionSession::ensureDecompressionSessionForSample):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (250989 => 250990)


--- trunk/Source/WebCore/ChangeLog	2019-10-10 21:38:55 UTC (rev 250989)
+++ trunk/Source/WebCore/ChangeLog	2019-10-10 21:56:16 UTC (rev 250990)
@@ -1,3 +1,18 @@
+2019-10-10  Jer Noble  <[email protected]>
+
+        [Catalina] LayoutTest fast/canvas/webgl/texImage2D-mse-flip-{true,false}.html failing
+        https://bugs.webkit.org/show_bug.cgi?id=202771
+        <rdar://problem/49441298>
+
+        Reviewed by Eric Carlson.
+
+        Catalina no longer creates IOSurface-backed CVPixelBuffers by default for certain
+        codecs; make the CVPixelBuffers generated by WebCoreDecompressionSession IOSurface-backed
+        explicitly by passing in the correct attributes when creating the VTDecompressionSession.
+
+        * platform/graphics/cocoa/WebCoreDecompressionSession.mm:
+        (WebCore::WebCoreDecompressionSession::ensureDecompressionSessionForSample):
+
 2019-10-10  Myles C. Maxfield  <[email protected]>
 
         [Cocoa] font-family:system-ui on Chinese systems don't get Chinese quote marks

Modified: trunk/Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm (250989 => 250990)


--- trunk/Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm	2019-10-10 21:38:55 UTC (rev 250989)
+++ trunk/Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm	2019-10-10 21:56:16 UTC (rev 250990)
@@ -223,9 +223,9 @@
         auto videoDecoderSpecification = @{ (__bridge NSString *)kVTVideoDecoderSpecification_EnableHardwareAcceleratedVideoDecoder: @YES };
 
         NSDictionary *attributes;
-        if (m_mode == OpenGL) {
-            attributes = nil;
-        } else {
+        if (m_mode == OpenGL)
+            attributes = @{ (__bridge NSString*)kCVPixelBufferIOSurfacePropertiesKey: @{ /* empty dictionary */ } };
+        else {
             ASSERT(m_mode == RGB);
             attributes = @{ (__bridge NSString *)kCVPixelBufferPixelFormatTypeKey: @(kCVPixelFormatType_32BGRA) };
         }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to