Title: [260106] trunk/JSTests
Revision
260106
Author
sbar...@apple.com
Date
2020-04-14 16:57:32 -0700 (Tue, 14 Apr 2020)

Log Message

Skip all low executable memory wasm tests on arm64
https://bugs.webkit.org/show_bug.cgi?id=210522

Reviewed by Tadeu Zagallo.

In my original JIT islands patch, I only skipped one of the "low executable
memory" tests. But the others are also causing problems on the iOS JSC test
runners, so let's just skip them all.

* wasm/lowExecutableMemory/exports-oom.js:
* wasm/lowExecutableMemory/imports-oom.js:

Modified Paths

Diff

Modified: trunk/JSTests/ChangeLog (260105 => 260106)


--- trunk/JSTests/ChangeLog	2020-04-14 23:54:29 UTC (rev 260105)
+++ trunk/JSTests/ChangeLog	2020-04-14 23:57:32 UTC (rev 260106)
@@ -1,3 +1,17 @@
+2020-04-14  Saam Barati  <sbar...@apple.com>
+
+        Skip all low executable memory wasm tests on arm64
+        https://bugs.webkit.org/show_bug.cgi?id=210522
+
+        Reviewed by Tadeu Zagallo.
+
+        In my original JIT islands patch, I only skipped one of the "low executable
+        memory" tests. But the others are also causing problems on the iOS JSC test
+        runners, so let's just skip them all.
+
+        * wasm/lowExecutableMemory/exports-oom.js:
+        * wasm/lowExecutableMemory/imports-oom.js:
+
 2020-04-14  Yusuke Suzuki  <ysuz...@apple.com>
 
         Unreviewed, reduce iteration count and introduce early return to make typed-array-subarray-can-throw-oom-error.js execution time short while throwing an error

Modified: trunk/JSTests/wasm/lowExecutableMemory/exports-oom.js (260105 => 260106)


--- trunk/JSTests/wasm/lowExecutableMemory/exports-oom.js	2020-04-14 23:54:29 UTC (rev 260105)
+++ trunk/JSTests/wasm/lowExecutableMemory/exports-oom.js	2020-04-14 23:57:32 UTC (rev 260106)
@@ -1,3 +1,7 @@
+// FIXME: Consider making jump islands work with Options::jitMemoryReservationSize
+// https://bugs.webkit.org/show_bug.cgi?id=209037
+//@ skip if $architecture == "arm64"
+
 import * as assert from '../assert.js'
 import Builder from '../Builder.js'
 

Modified: trunk/JSTests/wasm/lowExecutableMemory/imports-oom.js (260105 => 260106)


--- trunk/JSTests/wasm/lowExecutableMemory/imports-oom.js	2020-04-14 23:54:29 UTC (rev 260105)
+++ trunk/JSTests/wasm/lowExecutableMemory/imports-oom.js	2020-04-14 23:57:32 UTC (rev 260106)
@@ -1,3 +1,7 @@
+// FIXME: Consider making jump islands work with Options::jitMemoryReservationSize
+// https://bugs.webkit.org/show_bug.cgi?id=209037
+//@ skip if $architecture == "arm64"
+
 import * as assert from '../assert.js'
 import Builder from '../Builder.js'
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to