Title: [260108] trunk/Source/WebInspectorUI
- Revision
- 260108
- Author
- nvasil...@apple.com
- Date
- 2020-04-14 16:58:32 -0700 (Tue, 14 Apr 2020)
Log Message
Web Inspector: Don't show tooltips for tabs
https://bugs.webkit.org/show_bug.cgi?id=210464
Reviewed by Devin Rousso.
Don't show tooltips when they match the name of the tab. We no longer truncate tab names
so the tooltip is redundant.
Only show tooltips for settings and search (pinned tabs).
* UserInterface/Views/TabBarItem.js:
(WI.TabBarItem):
(WI.TabBarItem.prototype.set title):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (260107 => 260108)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-04-14 23:57:49 UTC (rev 260107)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-04-14 23:58:32 UTC (rev 260108)
@@ -1,3 +1,19 @@
+2020-04-14 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: Don't show tooltips for tabs
+ https://bugs.webkit.org/show_bug.cgi?id=210464
+
+ Reviewed by Devin Rousso.
+
+ Don't show tooltips when they match the name of the tab. We no longer truncate tab names
+ so the tooltip is redundant.
+
+ Only show tooltips for settings and search (pinned tabs).
+
+ * UserInterface/Views/TabBarItem.js:
+ (WI.TabBarItem):
+ (WI.TabBarItem.prototype.set title):
+
2020-04-14 Devin Rousso <drou...@apple.com>
Web Inspector: Elements: Computed: de-indent items in the Variables section so that wrapped content doesn't line up with the `--`
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBarItem.js (260107 => 260108)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBarItem.js 2020-04-14 23:57:49 UTC (rev 260107)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBarItem.js 2020-04-14 23:58:32 UTC (rev 260108)
@@ -46,7 +46,7 @@
this._element.createChild("div", "flex-space");
this.displayName = displayName;
- this.title = title || displayName;
+ this.title = title;
this.image = image;
}
@@ -130,7 +130,10 @@
this._title = title;
- this._element.title = this._title;
+ if (!this._title)
+ this._element.removeAttribute("title");
+ else
+ this._element.title = this._title;
}
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
