Title: [260922] trunk/Source/WebKit
- Revision
- 260922
- Author
- [email protected]
- Date
- 2020-04-29 16:08:01 -0700 (Wed, 29 Apr 2020)
Log Message
REGRESSION (r246395): Leak of ARQuickLookPreviewItem and ARQuickLookWebKitItem in -[_WKPreviewControllerDataSource previewController:previewItemAtIndex:]
<https://webkit.org/b/211197>
<rdar://problem/62612483>
Reviewed by Darin Adler.
* UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
(-[_WKPreviewControllerDataSource previewController:previewItemAtIndex:]):
- Use RetainPtr<> and adoptNS() to fix leaks.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (260921 => 260922)
--- trunk/Source/WebKit/ChangeLog 2020-04-29 22:45:31 UTC (rev 260921)
+++ trunk/Source/WebKit/ChangeLog 2020-04-29 23:08:01 UTC (rev 260922)
@@ -1,3 +1,15 @@
+2020-04-29 David Kilzer <[email protected]>
+
+ REGRESSION (r246395): Leak of ARQuickLookPreviewItem and ARQuickLookWebKitItem in -[_WKPreviewControllerDataSource previewController:previewItemAtIndex:]
+ <https://webkit.org/b/211197>
+ <rdar://problem/62612483>
+
+ Reviewed by Darin Adler.
+
+ * UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
+ (-[_WKPreviewControllerDataSource previewController:previewItemAtIndex:]):
+ - Use RetainPtr<> and adoptNS() to fix leaks.
+
2020-04-29 Per Arne Vollan <[email protected]>
Unreviewed sandbox compile fix.
Modified: trunk/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm (260921 => 260922)
--- trunk/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm 2020-04-29 22:45:31 UTC (rev 260921)
+++ trunk/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm 2020-04-29 23:08:01 UTC (rev 260922)
@@ -109,10 +109,10 @@
NSString *contentType = WebCore::UTIFromMIMEType("model/vnd.usdz+zip"_s);
#if HAVE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
- ARQuickLookPreviewItem *previewItem = [allocARQuickLookPreviewItemInstance() initWithFileAtURL:_downloadedURL];
- previewItem.canonicalWebPageURL = _originatingPageURL;
+ auto previewItem = adoptNS([allocARQuickLookPreviewItemInstance() initWithFileAtURL:_downloadedURL]);
+ [previewItem setCanonicalWebPageURL:_originatingPageURL];
- _item = [allocARQuickLookWebKitItemInstance() initWithPreviewItemProvider:_itemProvider.get() contentType:contentType previewTitle:@"Preview" fileSize:@(0) previewItem:previewItem];
+ _item = adoptNS([allocARQuickLookWebKitItemInstance() initWithPreviewItemProvider:_itemProvider.get() contentType:contentType previewTitle:@"Preview" fileSize:@(0) previewItem:previewItem.get()]);
[_item setDelegate:self];
if ([_item respondsToSelector:(@selector(setAdditionalParameters:))]) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
