Title: [260923] trunk/Source/WebKit
- Revision
- 260923
- Author
- [email protected]
- Date
- 2020-04-29 16:31:12 -0700 (Wed, 29 Apr 2020)
Log Message
REGRESSION(r260889): TestContextMenu:/webkit/WebKitWebView/populate-menu no longer passes
https://bugs.webkit.org/show_bug.cgi?id=211203
Reviewed by Aakash Jain.
No new tests needed.
* UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): Attach the correct action
group to the popover widget, instead of a temporary which will always be empty.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (260922 => 260923)
--- trunk/Source/WebKit/ChangeLog 2020-04-29 23:08:01 UTC (rev 260922)
+++ trunk/Source/WebKit/ChangeLog 2020-04-29 23:31:12 UTC (rev 260923)
@@ -1,3 +1,16 @@
+2020-04-29 Adrian Perez de Castro <[email protected]>
+
+ REGRESSION(r260889): TestContextMenu:/webkit/WebKitWebView/populate-menu no longer passes
+ https://bugs.webkit.org/show_bug.cgi?id=211203
+
+ Reviewed by Aakash Jain.
+
+ No new tests needed.
+
+ * UIProcess/gtk/WebContextMenuProxyGtk.cpp:
+ (WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): Attach the correct action
+ group to the popover widget, instead of a temporary which will always be empty.
+
2020-04-29 David Kilzer <[email protected]>
REGRESSION (r246395): Leak of ARQuickLookPreviewItem and ARQuickLookWebKitItem in -[_WKPreviewControllerDataSource previewController:previewItemAtIndex:]
Modified: trunk/Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp (260922 => 260923)
--- trunk/Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp 2020-04-29 23:08:01 UTC (rev 260922)
+++ trunk/Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp 2020-04-29 23:31:12 UTC (rev 260923)
@@ -193,8 +193,7 @@
{
gtk_popover_set_position(m_menu, GTK_POS_BOTTOM);
gtk_popover_set_relative_to(m_menu, m_webView);
- GRefPtr<GSimpleActionGroup> group = adoptGRef(g_simple_action_group_new());
- gtk_widget_insert_action_group(GTK_WIDGET(m_menu), gContextMenuItemGroup, G_ACTION_GROUP(group.get()));
+ gtk_widget_insert_action_group(GTK_WIDGET(m_menu), gContextMenuItemGroup, G_ACTION_GROUP(m_actionGroup.get()));
webkitWebViewBaseSetActiveContextMenuProxy(WEBKIT_WEB_VIEW_BASE(m_webView), this);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
