Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 124d36f180e38519cebcf56b356ea7e5e53b245b
https://github.com/WebKit/WebKit/commit/124d36f180e38519cebcf56b356ea7e5e53b245b
Author: Matt Woodrow <[email protected]>
Date: 2024-04-22 (Mon, 22 Apr 2024)
Changed paths:
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBoxModelObject.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h
Log Message:
-----------
[view-transitions] View transition pseudo elements should be anonymous.
https://bugs.webkit.org/show_bug.cgi?id=273056
Reviewed by Tim Nguyen.
We have existing code that expects renderers that return false from isAnonymous
to also have a valid Element.
Rather than making the view-transition pseudo elements not-anonymous, we
should instead change the consumers of isAnonymous so that these
pseudo-renderers
can still be containing blocks.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation const):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing const):
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::containingBlockForAutoHeightDetection const):
(WebCore::RenderBoxModelObject::requiresLayer const):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::isViewTransitionPseudo const): Deleted.
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::canCreateStackingContext):
(WebCore::RenderLayer::shouldBeCSSStackingContext const):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForViewTransition const):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
(WebCore::shouldBeAnonymous): Deleted.
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::isViewTransitionPseudo const):
(WebCore::RenderObject::isAnonymousForPercentageResolution const):
(WebCore::RenderObject::node const):
Canonical link: https://commits.webkit.org/277834@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
