Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff9ceff0e3c78e5c80ff0d55f972f0a0f585352e
      
https://github.com/WebKit/WebKit/commit/ff9ceff0e3c78e5c80ff0d55f972f0a0f585352e
  Author: Matt Woodrow <[email protected]>
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/RenderViewTransitionCapture.cpp
    M Source/WebCore/rendering/RenderViewTransitionCapture.h

  Log Message:
  -----------
  [view-transitions] Replaced content rect offset isn't respected when using 
layer attachment.
https://bugs.webkit.org/show_bug.cgi?id=273057

Reviewed by Tim Nguyen.

If the 'replaced content rect' starts outside of the content box (like happens 
with
`object-fit: none;`), then the layer attachment path doesn't handle this 
correctly.

Moves the addition of the replaced content rect location into the stored local 
overflow,
rather than doing so in a temporary in the painting code.

Adjusts the position of the attached layer by the difference between the 
renderer's
visual overflow rect, and where the capture layer actually begins (the local 
overflow
rect for the capture).

* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateTransform):
(WebCore::RenderLayerBacking::updateChildrenTransformAndAnchorPoint):
* Source/WebCore/rendering/RenderViewTransitionCapture.cpp:
(WebCore::RenderViewTransitionCapture::paintReplaced):
(WebCore::RenderViewTransitionCapture::layout):
(WebCore::RenderViewTransitionCapture::updateFromStyle):
(WebCore::RenderViewTransitionCapture::captureContentInset const):
(WebCore::RenderViewTransitionCapture::debugDescription const):
* Source/WebCore/rendering/RenderViewTransitionCapture.h:

Canonical link: https://commits.webkit.org/277835@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to