Title: [112440] trunk/Tools
- Revision
- 112440
- Author
- [email protected]
- Date
- 2012-03-28 14:21:50 -0700 (Wed, 28 Mar 2012)
Log Message
extract-built-product build step should fail if unzipping fails
https://bugs.webkit.org/show_bug.cgi?id=82493
Reviewed by Simon Fraser.
Forward non-zero exit code from subprocesses so that the master can detect any failures
and bail out early.
* BuildSlaveSupport/built-product-archive:
(main):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (112439 => 112440)
--- trunk/Tools/BuildSlaveSupport/built-product-archive 2012-03-28 21:18:20 UTC (rev 112439)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive 2012-03-28 21:21:50 UTC (rev 112440)
@@ -36,15 +36,18 @@
options, (action, ) = parser.parse_args()
if not options.platform:
parser.error("Platform is required")
+ return 1
if not options.configuration:
parser.error("Configuration is required")
+ return 1
if action not in ('archive', 'extract'):
parser.error("Action is required")
+ return 1
if action == 'archive':
- archiveBuiltProduct(options.configuration, options.platform)
+ return archiveBuiltProduct(options.configuration, options.platform)
else:
- extractBuiltProduct(options.configuration, options.platform)
+ return extractBuiltProduct(options.configuration, options.platform)
def archiveBuiltProduct(configuration, platform):
Modified: trunk/Tools/ChangeLog (112439 => 112440)
--- trunk/Tools/ChangeLog 2012-03-28 21:18:20 UTC (rev 112439)
+++ trunk/Tools/ChangeLog 2012-03-28 21:21:50 UTC (rev 112440)
@@ -1,3 +1,16 @@
+2012-03-28 Ryosuke Niwa <[email protected]>
+
+ extract-built-product build step should fail if unzipping fails
+ https://bugs.webkit.org/show_bug.cgi?id=82493
+
+ Reviewed by Simon Fraser.
+
+ Forward non-zero exit code from subprocesses so that the master can detect any failures
+ and bail out early.
+
+ * BuildSlaveSupport/built-product-archive:
+ (main):
+
2012-03-28 Dirk Pranke <[email protected]>
test-webkitpy should support files, directories, and packages as command line args
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
