Title: [112442] trunk/Tools
Revision
112442
Author
[email protected]
Date
2012-03-28 14:29:07 -0700 (Wed, 28 Mar 2012)

Log Message

flakiness dashboard should only keep the last 500 runs
https://bugs.webkit.org/show_bug.cgi?id=82530

Reviewed by Ojan Vafai.

If a bot has an overly large amount of failing tests, then
storing 750 runs' worth takes a lot of memory and CPU time to
process and we end up getting killed by AppEngine; this cases
data corruption and confusion down the road when we have to
retry the upload of the data and the tests show up as multiple
runs.

* TestResultServer/model/jsonresults.py:
(JsonResults.update_file):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (112441 => 112442)


--- trunk/Tools/ChangeLog	2012-03-28 21:26:56 UTC (rev 112441)
+++ trunk/Tools/ChangeLog	2012-03-28 21:29:07 UTC (rev 112442)
@@ -1,3 +1,20 @@
+2012-03-28  Dirk Pranke  <[email protected]>
+
+        flakiness dashboard should only keep the last 500 runs
+        https://bugs.webkit.org/show_bug.cgi?id=82530
+
+        Reviewed by Ojan Vafai.
+
+        If a bot has an overly large amount of failing tests, then
+        storing 750 runs' worth takes a lot of memory and CPU time to
+        process and we end up getting killed by AppEngine; this cases
+        data corruption and confusion down the road when we have to
+        retry the upload of the data and the tests show up as multiple
+        runs.
+
+        * TestResultServer/model/jsonresults.py:
+        (JsonResults.update_file):
+
 2012-03-28  Ryosuke Niwa  <[email protected]>
 
         extract-built-product build step should fail if unzipping fails

Modified: trunk/Tools/TestResultServer/model/jsonresults.py (112441 => 112442)


--- trunk/Tools/TestResultServer/model/jsonresults.py	2012-03-28 21:26:56 UTC (rev 112441)
+++ trunk/Tools/TestResultServer/model/jsonresults.py	2012-03-28 21:29:07 UTC (rev 112442)
@@ -48,7 +48,7 @@
 JSON_RESULTS_NO_DATA = "N"
 JSON_RESULTS_MIN_TIME = 5
 JSON_RESULTS_HIERARCHICAL_VERSION = 4
-JSON_RESULTS_MAX_BUILDS = 750
+JSON_RESULTS_MAX_BUILDS = 500
 JSON_RESULTS_MAX_BUILDS_SMALL = 200
 
 
@@ -306,7 +306,7 @@
             new_results = cls.merge(builder, file.data, incremental, num_runs)
         else:
             # Use the incremental data if there is no aggregated file to merge.
-            file = TestFile()            
+            file = TestFile()
             file.master = master
             file.builder = builder
             file.test_type = test_type
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to