Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3086ecb8f48307faa601ca1c6c2b2995f2903ee5
https://github.com/WebKit/WebKit/commit/3086ecb8f48307faa601ca1c6c2b2995f2903ee5
Author: Alan Baradlay <[email protected]>
Date: 2025-07-15 (Tue, 15 Jul 2025)
Changed paths:
M Source/WebCore/rendering/CaretRectComputation.cpp
M Source/WebCore/rendering/LegacyLineLayout.cpp
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlock.h
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderBoxModelObject.h
M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderInline.h
M Source/WebCore/rendering/RenderLineBreak.cpp
M Source/WebCore/rendering/RenderLineBreak.h
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/RenderListMarker.h
M Source/WebCore/rendering/RenderTextControl.cpp
M Source/WebCore/rendering/line/LineWidth.cpp
Log Message:
-----------
Remove LinePositionMode from RenderBoxModelObject::lineHeight
https://bugs.webkit.org/show_bug.cgi?id=295130
Reviewed by Antti Koivisto.
LinePositionMode has 2 values PositionOnContainingLine and
PositionOfInteriorLineBoxes.
PositionOnContainingLine is used at 3 places.
- we unconditionally ignore this value (see RenderInline and RenderLineBreak)
at 2 places.
- RenderBlock::baselinePosition passes in PositionOnContainingLine only when
"this" is _not_ isBlockLevelReplacedOrAtomicInline.
RenderBlock::lineHeight only uses PositionOnContainingLine when "this" _is_
isBlockLevelReplacedOrAtomicInline.
(Many override signatures also use PositionOnContainingLine as the default
value, but no callers utilizes this default behavior)
* Source/WebCore/rendering/CaretRectComputation.cpp:
(WebCore::computeCaretRectForEmptyElement):
* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::layoutLineBoxes):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight const):
(WebCore::RenderBlock::baselinePosition const):
(WebCore::RenderBlock::inlineBlockBaseline const):
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlockWithNoChildren):
(WebCore::RenderBlockFlow::layoutInFlowChildren):
(WebCore::RenderBlockFlow::adjustInitialLetterPosition):
(WebCore::RenderBlockFlow::inlineBlockBaseline const):
(WebCore::RenderBlockFlow::layoutInlineContent):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::lineHeight const):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::performFlexLayout):
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutGrid):
(WebCore::RenderGrid::layoutMasonry):
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::lineHeight const):
(WebCore::RenderInline::baselinePosition const):
* Source/WebCore/rendering/RenderInline.h:
* Source/WebCore/rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::lineHeight const):
(WebCore::RenderLineBreak::baselinePosition const):
* Source/WebCore/rendering/RenderLineBreak.h:
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::lineHeight const):
* Source/WebCore/rendering/RenderListMarker.h:
* Source/WebCore/rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight const):
* Source/WebCore/rendering/line/LineWidth.cpp:
(WebCore::LineWidth::updateAvailableWidth):
Canonical link: https://commits.webkit.org/297394@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
