Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 20237c4e8a8150b9c985a37f1560af95f6336a8f
https://github.com/WebKit/WebKit/commit/20237c4e8a8150b9c985a37f1560af95f6336a8f
Author: Ahmad Saleem <[email protected]>
Date: 2025-07-15 (Tue, 15 Jul 2025)
Changed paths:
A LayoutTests/svg/foreignObject/vertical-foreignObject-expected.html
A LayoutTests/svg/foreignObject/vertical-foreignObject.html
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.cpp
Log Message:
-----------
Fix vertical writing-mode, zoom and rounding issues for SVG `foreignObject`
https://bugs.webkit.org/show_bug.cgi?id=295863
Reviewed by Alan Baradlay.
This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.
This patch updates 'updateLogicalWidth' and 'computeLogicalHeight' to address
all FIXME and ensure that we handle vertical writing-mode and 'zoom' handling.
It also removes rounding and uses `LayoutUnit` now.
Merge (Test):
https://source.chromium.org/chromium/chromium/src/+/82ac602161c3c94c1c7dc979339a2908f71e71ca
For SVG zoom, we have other bugs - webkit.org/b/279041 & webkit.org/b/199236
Hence, there is no additional test added for it.
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.cpp:
(WebCore::LegacyRenderSVGForeignObject::updateLogicalWidth):
(WebCore::LegacyRenderSVGForeignObject::computeLogicalHeight const):
* LayoutTests/svg/foreignObject/vertical-foreignObject.html:
* LayoutTests/svg/foreignObject/vertical-foreignObject-expected.html:
Canonical link: https://commits.webkit.org/297395@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
