Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 67574dc9fe52eec1ba7626d6167d1067217ab57d
https://github.com/WebKit/WebKit/commit/67574dc9fe52eec1ba7626d6167d1067217ab57d
Author: Antoine Quint <grao...@webkit.org>
Date: 2025-08-22 (Fri, 22 Aug 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles-expected.txt
M Source/WebCore/animation/WebAnimation.cpp
M Source/WebCore/style/StyleExtractor.cpp
M Source/WebCore/style/StyleExtractor.h
Log Message:
-----------
[web-animations] `Animation.commitStyles()` does not commit custom properties
https://bugs.webkit.org/show_bug.cgi?id=297764
rdar://158919736
Reviewed by Tim Nguyen.
The `WebAnimation::commitStyles()` method applies effects in an effect stack on
a `RenderStyle`
object that is never associated directly with the animation effect's target
element. As such,
we must provide the `RenderStyle` object directly to the `Style::Extractor`
object being used,
just like we do in the CSSPropertyID case.
We add a new `customPropertyValueSerializationInStyle()` method to
`Style::Extractor` that we
call from `WebAnimation::commitStyles()` and refactor the existing
`customPropertyValueSerialization()`
to use it as well.
*
LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles-expected.txt:
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::commitStyles):
* Source/WebCore/style/StyleExtractor.cpp:
(WebCore::Style::Extractor::customPropertyValueSerialization const):
(WebCore::Style::Extractor::customPropertyValueSerializationInStyle const):
* Source/WebCore/style/StyleExtractor.h:
Canonical link: https://commits.webkit.org/299045@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
