Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4e4112627e57f523a8e1734a0f71269def888235
https://github.com/WebKit/WebKit/commit/4e4112627e57f523a8e1734a0f71269def888235
Author: David Kilzer <[email protected]>
Date: 2025-10-13 (Mon, 13 Oct 2025)
Changed paths:
M Source/WTF/wtf/RetainPtr.h
M Source/WTF/wtf/cocoa/Entitlements.mm
M Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm
M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
M Source/WebCore/editing/cocoa/AlternativeTextContextController.mm
M Source/WebCore/editing/cocoa/AttributedString.mm
M Source/WebCore/editing/cocoa/NodeHTMLConverter.mm
M Source/WebCore/page/cocoa/DataDetectionResultsStorage.h
M Source/WebCore/platform/cocoa/WebAVPlayerLayerView.mm
M Source/WebCore/platform/graphics/avfoundation/MediaPlaybackTargetCocoa.h
M Source/WebCore/platform/ios/wak/WAKWindow.mm
M Source/WebCore/platform/mac/PlatformScreenMac.mm
M Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm
M Source/WebCore/platform/mac/WidgetMac.mm
M Source/WebCore/platform/text/cocoa/LocalizedDateCache.mm
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm
M Source/WebKit/Platform/cocoa/CocoaHelpers.h
M Source/WebKit/UIProcess/API/Cocoa/WKDownload.mm
M Source/WebKit/UIProcess/API/Cocoa/WKScriptMessage.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKDataTask.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKWebPushMessage.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKWebPushSubscriptionData.mm
M Source/WebKit/UIProcess/ApplicationStateTracker.mm
M Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm
M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
M Source/WebKit/UIProcess/Cocoa/WKContactPicker.mm
M Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm
M Source/WebKit/UIProcess/DigitalCredentials/WKDigitalCredentialsPicker.mm
M Source/WebKit/UIProcess/Inspector/mac/WKInspectorViewController.mm
M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm
M Source/WebKit/UIProcess/ios/DragDropInteractionState.mm
M Source/WebKit/UIProcess/ios/UIKitUtilities.mm
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/ios/WKHighlightLongPressGestureRecognizer.mm
M Source/WebKit/UIProcess/ios/WKScrollView.mm
M Source/WebKit/UIProcess/ios/WKTextInteractionWrapper.mm
M Source/WebKit/UIProcess/ios/forms/WKFocusedFormControlView.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
M Source/WebKit/UIProcess/mac/PageClientImplMac.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.mm
M
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm
M Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm
M Source/WebKit/webpushd/_WKMockUserNotificationCenter.mm
M Source/WebKitLegacy/mac/History/WebHistory.mm
M Source/WebKitLegacy/mac/Misc/WebSharingServicePickerController.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.mm
M Source/WebKitLegacy/mac/WebView/WebView.mm
M Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm
M Tools/TestWebKitAPI/Tests/WebKit/MediaSessionCoordinatorTest.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm
M Tools/TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm
M Tools/TestWebKitAPI/Tests/mac/WKWebViewForTestingImmediateActions.mm
M Tools/TestWebKitAPI/cocoa/TestContextMenuDriver.mm
M Tools/TestWebKitAPI/mac/TestDraggingInfo.mm
M Tools/TestWebKitAPI/mac/TestFilePromiseReceiver.mm
M Tools/TestWebKitAPI/mac/TestInspectorBar.mm
M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm
M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm
Log Message:
-----------
Adopt LIFETIME_BOUND for WTF::RetainPtr
<https://bugs.webkit.org/show_bug.cgi?id=300594>
<rdar://162489676>
Reviewed by Geoffrey Garen.
Introduce RetainPtr::unsafeGet() for pre-existing unsafe uses of
RetainPtr::get().
* Source/WTF/wtf/RetainPtr.h:
(WTF::RetainPtr::unsafeGet const):
(WTF::RetainPtr::get const): Deleted.
(WTF::RetainPtr::operator-> const): Deleted.
(WTF::RetainPtr::operator PtrType const): Deleted.
* Source/WTF/wtf/cocoa/Entitlements.mm:
(WTF::hasEntitlementValueInArray):
- Avoid switching to unsafeGet() and remove C-style cast by switching to
dynamic_cf_cast<CFArrayRef>() first.
* Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:
(WebCore::AXRemoteFrame::initializePlatformElementWithRemoteToken):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapper accessibilityElements]):
(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::platformWidget const):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(makeNSArray):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):
(transformSpecialChildrenCases):
(children):
(scrollViewParent):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper
_accessibilityHitTest:returnPlatformElements:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
* Source/WebCore/editing/cocoa/AlternativeTextContextController.mm:
(WebCore::AlternativeTextContextController::alternativesForContext const):
* Source/WebCore/editing/cocoa/AttributedString.mm:
(WebCore::reconstructStyle):
* Source/WebCore/editing/cocoa/NodeHTMLConverter.mm:
(HTMLConverter::aggregatedAttributesForElementAndItsAncestors):
* Source/WebCore/page/cocoa/DataDetectionResultsStorage.h:
(WebCore::DataDetectionResultsStorage::imageOverlayDataDetectionResult):
* Source/WebCore/platform/cocoa/WebAVPlayerLayerView.mm:
(WebCore::WebAVPlayerLayerView_pictureInPicturePlayerLayerView):
* Source/WebCore/platform/graphics/avfoundation/MediaPlaybackTargetCocoa.h:
* Source/WebCore/platform/ios/wak/WAKWindow.mm:
(-[WAKWindow contentReplacementImage]):
* Source/WebCore/platform/mac/PlatformScreenMac.mm:
(WebCore::screen):
* Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:
(-[WebCoreFullScreenPlaceholderView target]):
* Source/WebCore/platform/mac/WidgetMac.mm:
(WebCore::Widget::outerView const):
* Source/WebCore/platform/text/cocoa/LocalizedDateCache.mm:
(WebCore::LocalizedDateCache::formatterForDateType):
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
* Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm:
* Source/WebKit/Platform/cocoa/CocoaHelpers.h:
(WebKit::toCocoaImage):
* Source/WebKit/UIProcess/API/Cocoa/WKDownload.mm:
(-[WKDownload delegate]):
* Source/WebKit/UIProcess/API/Cocoa/WKScriptMessage.mm:
(-[WKScriptMessage name]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _delegate]):
* Source/WebKit/UIProcess/API/Cocoa/_WKDataTask.mm:
(-[_WKDataTask webView]):
* Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm:
(-[_WKInspector delegate]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebPushMessage.mm:
(-[_WKWebPushMessage data]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebPushSubscriptionData.mm:
(-[_WKWebPushSubscriptionData applicationServerKey]):
(-[_WKWebPushSubscriptionData authenticationSecret]):
(-[_WKWebPushSubscriptionData ecdhPublicKey]):
* Source/WebKit/UIProcess/ApplicationStateTracker.mm:
(WebKit::ApplicationStateTracker::setWindow):
* Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:
(WebKit::ModelElementController::previewForModelIdentifier):
* Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::uiDelegatePrivate):
* Source/WebKit/UIProcess/Cocoa/WKContactPicker.mm:
(-[WKContactPicker delegate]):
* Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm:
(-[WKShareSheet delegate]):
* Source/WebKit/UIProcess/DigitalCredentials/WKDigitalCredentialsPicker.mm:
(-[WKDigitalCredentialsPicker delegate]):
* Source/WebKit/UIProcess/Inspector/mac/WKInspectorViewController.mm:
(-[WKInspectorViewController _horizontallyAttachedInspectedWebView]):
* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
(-[UIView _web_findDescendantViewAtPoint:withEvent:]):
* Source/WebKit/UIProcess/ios/DragDropInteractionState.mm:
(WebKit::DragDropInteractionState::defaultDropPreview const):
(WebKit::DragDropInteractionState::finalDropPreview const):
* Source/WebKit/UIProcess/ios/UIKitUtilities.mm:
(-[UIView _wk_parentScrollView]):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView copySubjectResultForImageContextMenu]):
(-[WKContentView machineReadableCodeSubMenuForImageContextMenu]):
(-[WKContentView _selectionContainerViewInternal]):
* Source/WebKit/UIProcess/ios/WKHighlightLongPressGestureRecognizer.mm:
(-[WKHighlightLongPressGestureRecognizer lastTouchedScrollView]):
* Source/WebKit/UIProcess/ios/WKScrollView.mm:
(-[WKScrollView _wk_topEdgeEffect]):
(-[WKScrollView _wk_leftEdgeEffect]):
(-[WKScrollView _wk_rightEdgeEffect]):
(-[WKScrollView _wk_bottomEdgeEffect]):
* Source/WebKit/UIProcess/ios/WKTextInteractionWrapper.mm:
(-[WKTextInteractionWrapper textSelectionDisplayInteraction]):
(-[WKTextInteractionWrapper prepareToMoveSelectionContainer:]):
* Source/WebKit/UIProcess/ios/forms/WKFocusedFormControlView.mm:
(-[WKFocusedFormControlView delegate]):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController delegate]):
* Source/WebKit/UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::activeView const):
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::accessibilityFocusedUIElement):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFPluginAccessibilityObject parent]):
* Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.mm:
(-[WKAccessibilityPDFDocumentObject accessibilityParent]):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:
(WebKit::createAnimation):
* Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):
* Source/WebKit/webpushd/_WKMockUserNotificationCenter.mm:
(-[_WKMockUserNotificationCenter notificationSettings]):
* Source/WebKitLegacy/mac/History/WebHistory.mm:
(-[WebHistoryPrivate insertItem:forDateKey:]):
(-[WebHistoryPrivate orderedItemsLastVisitedOnDay:]):
(WebHistoryWriter::writeHistoryItems):
* Source/WebKitLegacy/mac/Misc/WebSharingServicePickerController.mm:
(-[WebSharingServicePickerController
sharingService:transitionImageForShareItem:contentRect:]):
(-[WebSharingServicePickerController
sharingService:sourceWindowForShareItems:sharingContentScope:]):
* Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.mm:
(WebDragClient::startDrag):
* Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::save):
(-[WebInspectorWindowController window]):
* Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.mm:
(WebNotificationClient::cancel):
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _startDrag:]):
(-[WebView _objectForIdentifier:]):
* Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
(+[DumpRenderTreePasteboard _pasteboardWithName:]):
(-[LocalPasteboard dataForType:]):
* Tools/TestWebKitAPI/Tests/WebKit/MediaSessionCoordinatorTest.mm:
(-[_WKMockMediaSessionCoordinator lastStateChange]):
(-[_WKMockMediaSessionCoordinator lastMethodCalled]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
(TEST_F(WKContentRuleListStoreTest, ModifyHeaders)):
(TEST_F(WKContentRuleListStoreTest,
ModifyHeadersWithCompetingRulesWhereAppendWins)):
(TEST_F(WKContentRuleListStoreTest,
ModifyHeadersWithCompetingRulesWhereSetWins)):
(TEST_F(WKContentRuleListStoreTest,
ModifyHeadersWithCompetingRulesWhereRemoveWins)):
(TEST_F(WKContentRuleListStoreTest, ModifyHeadersWithMultipleRuleLists)):
(TEST_F(WKContentRuleListStoreTest, Redirect)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
(TestWebKitAPI::TEST(WKWebView,
SnapshotImageEmptyWithOutOfScopeCompletionHandler)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:
* Tools/TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
(TestWebKitAPI::webViewAfterPerformingDragOperation):
* Tools/TestWebKitAPI/Tests/mac/WKWebViewForTestingImmediateActions.mm:
(-[WKWebViewForTestingImmediateActions immediateActionGesture]):
* Tools/TestWebKitAPI/cocoa/TestContextMenuDriver.mm:
(-[TestContextMenuDriver delegate]):
(-[TestContextMenuDriver view]):
* Tools/TestWebKitAPI/mac/TestDraggingInfo.mm:
(-[TestDraggingInfo draggingSource]):
* Tools/TestWebKitAPI/mac/TestFilePromiseReceiver.mm:
(-[TestFilePromiseReceiver draggingSource]):
* Tools/TestWebKitAPI/mac/TestInspectorBar.mm:
(-[TestInspectorBarItemController inspectorBar]):
(-[TestInspectorBar itemController]):
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::horizontalScrollbar const):
(WTR::AccessibilityUIElement::verticalScrollbar const):
(WTR::AccessibilityUIElement::focusableAncestor):
(WTR::AccessibilityUIElement::editableAncestor):
(WTR::AccessibilityUIElement::highestEditableAncestor):
* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(-[UIView _wtr_frontmostViewAtPoint:]):
Canonical link: https://commits.webkit.org/301419@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
