Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0669e3ca82a2c6da0b973c22806fe2d9674eed8b
      
https://github.com/WebKit/WebKit/commit/0669e3ca82a2c6da0b973c22806fe2d9674eed8b
  Author: Kimmo Kinnunen <[email protected]>
  Date:   2025-10-09 (Thu, 09 Oct 2025)

  Changed paths:
    A PerformanceTests/Canvas/WebGL-getAttribLocation-getUniformLocation.html
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.h
    M Source/WebCore/html/canvas/WebGLUniformLocation.cpp
    M Source/WebCore/html/canvas/WebGLUniformLocation.h

  Log Message:
  -----------
  WebGLRenderingContextBase::getUniformLocation spends time resolving uniform 
type
https://bugs.webkit.org/show_bug.cgi?id=300386
rdar://162191254

Reviewed by Dan Glastonbury.

Return the uniform location without resolving the type to speed up this
common operation.

The uniform type is needed when getting the uniform value. The type can
be resolved at that moment.

Improves the added test from 500 to 1500 iterations.

* PerformanceTests/Canvas/WebGL-getAttribLocation-getUniformLocation.html: 
Added.
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::getUniform):
(WebCore::WebGLRenderingContextBase::getUniformLocation):
* Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
* Source/WebCore/html/canvas/WebGLUniformLocation.cpp:
(WebCore::WebGLUniformLocation::create):
(WebCore::WebGLUniformLocation::WebGLUniformLocation):
(WebCore::WebGLUniformLocation::type const):
(WebCore::WebGLUniformLocation::setType):
* Source/WebCore/html/canvas/WebGLUniformLocation.h:

Canonical link: https://commits.webkit.org/301300@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to