Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6264e5e9e22e06ecb92f44e11892713bbce07a09
https://github.com/WebKit/WebKit/commit/6264e5e9e22e06ecb92f44e11892713bbce07a09
Author: Jean Haberer <[email protected]>
Date: 2025-11-27 (Thu, 27 Nov 2025)
Changed paths:
A
LayoutTests/model-element/immersive/model-element-immersive-basic-expected.txt
A LayoutTests/model-element/immersive/model-element-immersive-basic.html
A
LayoutTests/model-element/immersive/model-element-immersive-no-client-approval-expected.txt
A
LayoutTests/model-element/immersive/model-element-immersive-no-client-approval.html
R LayoutTests/model-element/model-element-immersive-expected.txt
R LayoutTests/model-element/model-element-immersive.html
M Source/WebCore/dom/DocumentImmersive.cpp
M Source/WebCore/page/ChromeClient.h
M Source/WebKit/Shared/API/Cocoa/WebKitPrivate.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
A Source/WebKit/UIProcess/API/Cocoa/_WKImmersiveEnvironmentDelegate.h
M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm
M Source/WebKit/UIProcess/PageClient.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Tools/WebKitTestRunner/TestOptions.cpp
M Tools/WebKitTestRunner/TestOptions.h
M Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h
M Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm
M Tools/WebKitTestRunner/ios/TestControllerIOS.mm
Log Message:
-----------
Ask the client before pursuing an immersive request
https://bugs.webkit.org/show_bug.cgi?id=303145
rdar://165447324
Reviewed by Etienne Segonzac.
Add a WK delegate protocol to communicate with the client and ask consent
before pursuing an immersive request.
Tests: model-element/immersive/model-element-immersive-basic.html
model-element/immersive/model-element-immersive-no-client-approval.html
*
LayoutTests/model-element/immersive/model-element-immersive-basic-expected.txt:
Added.
* LayoutTests/model-element/immersive/model-element-immersive-basic.html:
Renamed from LayoutTests/model-element/model-element-immersive.html.
*
LayoutTests/model-element/immersive/model-element-immersive-no-client-approval-expected.txt:
Added.
*
LayoutTests/model-element/immersive/model-element-immersive-no-client-approval.html:
Added.
* LayoutTests/model-element/model-element-immersive-expected.txt: Removed.
Move the immersive-related model element tests inside a subfolder,
and add a test that verifies that an immersive request fails if the client
doesn't allow it.
* Source/WebCore/dom/DocumentImmersive.cpp:
(WebCore::DocumentImmersive::requestImmersive):
Add checks before pursuing an immersive request.
* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::canEnterImmersiveElement const):
* Source/WebKit/Shared/API/Cocoa/WebKitPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _immersiveEnvironmentDelegate]):
(-[WKWebView _setImmersiveEnvironmentDelegate:]):
(-[WKWebView _canEnterImmersiveElementFromURL:completion:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKImmersiveEnvironmentDelegate.h: Added.
New delegate protocol to communicate with the client for immersive-related
actions.
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::canEnterImmersiveElementFromURL):
* Source/WebKit/UIProcess/PageClient.h:
(WebKit::PageClient::canEnterImmersiveElementFromURL):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::canEnterImmersiveElementFromURL):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::canEnterImmersiveElement const):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::canEnterImmersiveElement):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
Plumbing the request up to the UI Process.
* Tools/WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults):
(WTR::TestOptions::keyTypeMapping):
* Tools/WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::shouldAcceptImmersiveEnvironmentRequests const):
* Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
* Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView initWithFrame:configuration:]):
(-[TestRunnerWKWebView
webView:canPresentImmersiveEnvironmentFromURL:completion:]):
* Tools/WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformResetStateToConsistentValues):
Add a test option that forces the test runner to either allow or disallow
immersive presentations.
Canonical link: https://commits.webkit.org/303611@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
