Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8c49347784a651cdd58173ebb4c61bafa2748145
https://github.com/WebKit/WebKit/commit/8c49347784a651cdd58173ebb4c61bafa2748145
Author: CGQAQ <[email protected]>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M Tools/Scripts/webkitdirs.pm
Log Message:
-----------
Fix `run-webkit-tests` won't open results.html correctly issue
https://bugs.webkit.org/show_bug.cgi?id=307425
Reviewed by Jonathan Bedard.
run-webkit-tests script opens a blank page when there are failing tests instead
of the results.html, this PR fixes that.
NOTE: this PR change is created by codex AI, I personally don't know Perl, I
only tested on my MBP and it worked for me.
Here's codex explanation::
The blank page was a launch-path bug, not a results-generation bug.
- results.html and full_results.json were being generated correctly.
- The old Darwin flow launched Safari binary via run-safari with -NSOpen
<path>.
- On current Safari/SafariForWebKitDevelopment, that direct-binary -NSOpen
path no longer reliably triggers “open
this document”; Safari starts but opens an empty tab.
- When we passed a file: URL there, that path got mangled into .../file:/...,
confirming that argument route was
wrong.
Why it works now:
- run-safari still handles WebKit env/config, but -NSOpen is now routed
through LaunchServices (open -a Safari.app
<file> --args ...), which correctly delivers the file-open event to Safari.
* Tools/Scripts/webkitdirs.pm:
(runMacWebKitApp):
(runSafari):
Canonical link: https://commits.webkit.org/308077@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
