Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 179786d4aad8c80aa127bf16a4ecb411790f2522
https://github.com/WebKit/WebKit/commit/179786d4aad8c80aa127bf16a4ecb411790f2522
Author: Ruthvik Konda <[email protected]>
Date: 2026-04-24 (Fri, 24 Apr 2026)
Changed paths:
M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
M Source/WebCore/Modules/model-element/HTMLModelElement.h
M Source/WebCore/Modules/model-element/ModelPlayer.h
M Source/WebCore/Modules/model-element/PlaceholderModelPlayer.cpp
M Source/WebCore/Modules/model-element/PlaceholderModelPlayer.h
M Source/WebCore/Modules/model-element/dummy/DummyModelPlayer.cpp
M Source/WebCore/Modules/model-element/dummy/DummyModelPlayer.h
M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h
M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h
M Source/WebKit/WebProcess/Model/WebModelPlayer.h
M Source/WebKit/WebProcess/Model/WebModelPlayer.mm
Log Message:
-----------
Remove vestigial `hasAudio`/`isMuted`/`setIsMuted` from `<model>` after
310669@main
https://bugs.webkit.org/show_bug.cgi?id=313249
rdar://175526183
Reviewed by Mike Wyrzykowski.
Commit 310669@main removed the ARKit inline preview feature including the
working `ASVInlinePreview` audio backend, the IDL exposure on
`HTMLModelElement`, and `WebPageProxy` IPC for the audio API. Left behind
were the wrapper methods on `HTMLModelElement`, the corresponding pure
virtuals on `ModelPlayer`, and 5 no-op subclass overrides.
No new tests needed (no behavioral change).
* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::hasAudio): Deleted.
(WebCore::HTMLModelElement::isMuted): Deleted.
(WebCore::HTMLModelElement::setIsMuted): Deleted.
* Source/WebCore/Modules/model-element/HTMLModelElement.h:
* Source/WebCore/Modules/model-element/ModelPlayer.h:
* Source/WebCore/Modules/model-element/PlaceholderModelPlayer.cpp:
(WebCore::PlaceholderModelPlayer::hasAudio): Deleted.
(WebCore::PlaceholderModelPlayer::isMuted): Deleted.
(WebCore::PlaceholderModelPlayer::setIsMuted): Deleted.
* Source/WebCore/Modules/model-element/PlaceholderModelPlayer.h:
* Source/WebCore/Modules/model-element/dummy/DummyModelPlayer.cpp:
(WebCore::DummyModelPlayer::hasAudio): Deleted.
(WebCore::DummyModelPlayer::isMuted): Deleted.
(WebCore::DummyModelPlayer::setIsMuted): Deleted.
* Source/WebCore/Modules/model-element/dummy/DummyModelPlayer.h:
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h:
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::ModelProcessModelPlayerProxy::hasAudio): Deleted.
(WebKit::ModelProcessModelPlayerProxy::isMuted): Deleted.
(WebKit::ModelProcessModelPlayerProxy::setIsMuted): Deleted.
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp:
(WebKit::ModelProcessModelPlayer::hasAudio): Deleted.
(WebKit::ModelProcessModelPlayer::isMuted): Deleted.
(WebKit::ModelProcessModelPlayer::setIsMuted): Deleted.
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h:
* Source/WebKit/WebProcess/Model/WebModelPlayer.h:
* Source/WebKit/WebProcess/Model/WebModelPlayer.mm:
(WebKit::WebModelPlayer::hasAudio): Deleted.
(WebKit::WebModelPlayer::isMuted): Deleted.
(WebKit::WebModelPlayer::setIsMuted): Deleted.
Canonical link: https://commits.webkit.org/311995@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
