Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 32614fdd7519c135559ebb061e7df54f13c51d49
https://github.com/WebKit/WebKit/commit/32614fdd7519c135559ebb061e7df54f13c51d49
Author: Alan Baradlay <[email protected]>
Date: 2026-04-24 (Fri, 24 Apr 2026)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/fast/css/counters/counter-list-item-expected.html
M LayoutTests/fast/css/counters/counter-list-item.html
M LayoutTests/fast/lists/ol-reversed-dynamic-expected.txt
M LayoutTests/fast/lists/ol-reversed-dynamic.html
M LayoutTests/fast/lists/ol-reversed-nested-items-expected.txt
M LayoutTests/fast/lists/ol-reversed-nested-items.html
M LayoutTests/fast/lists/ol-reversed-simple-expected.txt
M LayoutTests/fast/lists/ol-reversed-simple.html
M LayoutTests/fast/lists/ol-reversed-simple.xhtml
M Source/WebCore/html/HTMLOListElement.h
M Source/WebCore/rendering/RenderCounter.cpp
M Source/WebCore/rendering/RenderListItem.cpp
M Source/WebCore/rendering/RenderListItem.h
Log Message:
-----------
Fix imported/w3c/web-platform-tests/css/css-lists/li-value-reversed-001.html
-002.html and -003.html
https://bugs.webkit.org/show_bug.cgi?id=313238
Reviewed by Antti Koivisto.
When <ol reversed> has an <li value=X>, items before it should count
up from X. For example:
<ol reversed>
<li>seven <!-- should be 7 (= 1 item before value=6, plus 6) -->
<li value=6>six
<li>five <!-- 6 - 1 = 5 -->
</ol>
We show 3, 6, 5 because the starting value was computed as
itemCount() (= 3) without considering the explicit value that comes later.
The fix scans list items forward looking for the first explicit value.
When found, the starting value = items before it + the explicit value.
When no explicit value is found, falls back to itemCount() as before.
* LayoutTests/TestExpectations:
* LayoutTests/fast/css/counters/counter-list-item-expected.html:
* LayoutTests/fast/css/counters/counter-list-item.html:
* LayoutTests/fast/lists/ol-reversed-dynamic-expected.txt:
* LayoutTests/fast/lists/ol-reversed-dynamic.html:
* LayoutTests/fast/lists/ol-reversed-nested-items-expected.txt:
* LayoutTests/fast/lists/ol-reversed-nested-items.html:
* LayoutTests/fast/lists/ol-reversed-simple-expected.txt:
* LayoutTests/fast/lists/ol-reversed-simple.html:
* LayoutTests/fast/lists/ol-reversed-simple.xhtml:
* Source/WebCore/html/HTMLOListElement.h:
* Source/WebCore/rendering/RenderCounter.cpp:
(WebCore::listItemCounterDirectives):
* Source/WebCore/rendering/RenderListItem.cpp:
(WebCore::RenderListItem::startForReversedOrderedList):
(WebCore::RenderListItem::updateValueNow const):
Test changes: progression.
* Source/WebCore/rendering/RenderListItem.h:
Canonical link: https://commits.webkit.org/311996@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
